Add RemoteS3ConnectionProvider plugin implementations #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosiac1
force-pushed
the
feat/refactor/plugin-impls
branch
3 times, most recently
from
bc398e6 to
801e9a1
Compare
mosiac1
force-pushed
the
feat/refactor-remote
branch
from
00c4af6 to
abd2f9d
Compare
mosiac1
force-pushed
the
feat/refactor-remote
branch
from
2dc5219 to
7c495ea
Compare
mosiac1
force-pushed
the
feat/refactor/plugin-impls
branch
from
801e9a1 to
c4ec16b
Compare
mosiac1
force-pushed
the
feat/refactor/plugin-impls
branch
from
c4ec16b to
6547f3a
Compare
mosiac1
force-pushed
the
feat/refactor/plugin-impls
branch
from
6547f3a to
85a33f4
Compare
pranavr12
reviewed
May 16, 2025
| private String accessKey; | ||
| private String secretKey; | ||
|
|
||
| @NotNull |
There was a problem hiding this comment.
The annotations can be moved to the fields
There was a problem hiding this comment.
In all other Airlift conflig classes we use the annotations on getters
...io/trino/aws/proxy/server/remote/provider/config/ConfigRemoteS3ConnectionProviderModule.java
Outdated
Show resolved
Hide resolved
| this.requestQueryFields = config.getRequestFields(); | ||
| this.objectMapper = requireNonNull(objectMapper, "objectMapper is null"); | ||
| if (config.getCacheSize() > 0) { | ||
| this.cache = Optional.of(newBuilder() |
There was a problem hiding this comment.
Suggested change
| this.cache = Optional.of(newBuilder() | |
| this.cache = config.getCacheSize() > 0 ? ..... : Optional.empty(); |
We can use a ternary op
There was a problem hiding this comment.
That line is already pretty long, I think a ternary would make it more complex. I would like to avoid it
...main/java/io/trino/aws/proxy/server/remote/provider/http/HttpRemoteS3ConnectionProvider.java
Outdated
Show resolved
Hide resolved
| prepareGet().setUri(uriBuilder.build()).build(), | ||
| createFullJsonResponseHandler(responseCodec)); | ||
| HttpStatus statusCode = HttpStatus.fromStatusCode(response.getStatusCode()); | ||
| if (statusCode.family() != HttpStatus.Family.SUCCESSFUL) { |
There was a problem hiding this comment.
Since the only valid response is when the both HttpStatus.Family.SUCCESSFUL and response.hasValue() are true, we can check for this first and then go into invalid scenarios.
There was a problem hiding this comment.
This is a bit of personal preference, but i like function logic to go like
if (badCase) {
....
}
return goodCase
| { | ||
| this.httpClient = requireNonNull(httpClient, "httpClient is null"); | ||
| this.responseCodec = requireNonNull(responseCodec, "responseCodec is null"); | ||
| this.endpoint = config.getEndpoint(); |
There was a problem hiding this comment.
Suggested change
| this.endpoint = config.getEndpoint(); | |
| this.endpoint = requireNotNull(config.getEndpoint()); |
There was a problem hiding this comment.
This field cannot be null since its in a config class and its annotated @NotNull
We usually trust the config validation and don't re-do it.
| this.httpClient = requireNonNull(httpClient, "httpClient is null"); | ||
| this.responseCodec = requireNonNull(responseCodec, "responseCodec is null"); | ||
| this.endpoint = config.getEndpoint(); | ||
| this.requestQueryFields = config.getRequestFields(); |
There was a problem hiding this comment.
Suggested change
| this.requestQueryFields = config.getRequestFields(); | |
| this.requestQueryFields = requireNonNull(config.getRequestFields()); |
...io/trino/aws/proxy/server/remote/provider/config/ConfigRemoteS3ConnectionProviderConfig.java
Outdated
Show resolved
Hide resolved
Added generic implementations for the RemoteS3ConnectionProvider interface: static, file and http. Added a README for the file and http ones as those are a bit more complex. Added more tests to dynamic RemoteS3Facade creation
mosiac1
force-pushed
the
feat/refactor/plugin-impls
branch
from
85a33f4 to
a662e45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add generic implementations for the RemoteS3ConnectionProvider interface.
config, file and http
Added a README for the file and http ones as those are a bit more complex