Skip to content

feat(Traefik Hub): improve UserXP on token #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(Traefik Hub): improve UserXP on token #1397

wants to merge 1 commit into from
+23 −5

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented May 5, 2025

What does this PR do?

This PR improves the UX when setting the hub token value.

  • If the token is less or equal to 64 characters, then consider as the secret name
  • if the token is greater or equal to 65 characters, then consider as the token value

Motivation

Improve user experience and avoid hidden value

More

  • Yes, I updated the tests accordingly
  • Yes, I updated the schema accordingly
  • Yes, I ran make test and all the tests passed

@mmatur mmatur requested a review from mloiseleur May 5, 2025 08:22
@mloiseleur mloiseleur changed the title feat: improve UX for hub token feat(Traefik Hub): improve UX for hub token May 5, 2025
@mloiseleur mloiseleur changed the title feat(Traefik Hub): improve UX for hub token feat(Traefik Hub): improve UserXP on token May 5, 2025
mloiseleur
mloiseleur approved these changes May 5, 2025
View reviewed changes
Copy link
Member

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LSTM

@mloiseleur mloiseleur requested a review from darkweaver87 May 5, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloiseleur mloiseleur mloiseleur approved these changes

@darkweaver87 darkweaver87 Awaiting requested review from darkweaver87

Assignees
No one assigned
Labels
kind/enhancement New feature or request status/2-needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmatur @mloiseleur