-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
git-terminal.md: add commands to update a fork and change email #5956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git-terminal.md: add commands to update a fork and change email #5956
Conversation
You can add the new |
I, to be honest, don't know how to fetch upstream between forks, I have just been using the really useful new fetch upstream button, so thanks for this. |
Co-authored-by: CleanMachine1 <[email protected]> Co-authored-by: bl-ue <[email protected]>
Co-authored-by: Starbeamrainbowlabs <[email protected]>
Co-authored-by: Axel Navarro <[email protected]> Co-authored-by: CleanMachine1 <[email protected]>
Co-authored-by: Axel Navarro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Says my review is required so here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @marchersimon!
Co-authored-by: bl-ue <[email protected]>
Co-authored-by: bl-ue <[email protected]>
Co-authored-by: bl-ue <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one minor comment.
Co-authored-by: Owen Voke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A great reference to refer people to when reviewing PRs!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@SethFalco care to give this PR a review? If not, we can merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're using title case for the h1 at the top, but then sentence case for the h2s?
It feels a bit inconsistent for me, any opinions? (More Info)
Some changes are subjective, so don't be afraid to dispute them.
The only one I'm somewhat firm on would be the 28 syllable clause. Try reading all of that in one breath!
Could the image(s) be made into a dark theme instead of light. How many people use dimmed/dark over black on white |
To be honest, I find it unlikely that most use dark mode. I assume that'd be light theme, or system preferences. (But all major operating systems default to light, anyway.) |
Its not a big deal. I'm fine with "default settings" being used. |
I originally used dark theme, but @ bl-ue suggested to use the default one here. I understand the decision even tough a dark image in light mode isn't as bad as a light image in dark mode. |
Merging, since there are already 5 approvals |
Many new contributors don't know how to update their forks and change their commit email if they have trouble with CLAssistant.
git-terminal.md
seems like the perfect place to document that. Feel free to reword anything.