Skip to content

git-terminal.md: add commands to update a fork and change email #5956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jun 29, 2021

Conversation

marchersimon
Copy link
Collaborator

Many new contributors don't know how to update their forks and change their commit email if they have trouble with CLAssistant. git-terminal.md seems like the perfect place to document that. Feel free to reword anything.

@marchersimon marchersimon added the documentation Issues/PRs modifying the documentation. label May 13, 2021
@navarroaxel
Copy link
Collaborator

You can add the new Fetch upstream button https://twitter.com/github/status/1390382527588798477

@CleanMachine1
Copy link
Member

I, to be honest, don't know how to fetch upstream between forks, I have just been using the really useful new fetch upstream button, so thanks for this.

Co-authored-by: CleanMachine1 <[email protected]>
Co-authored-by: bl-ue <[email protected]>
Co-authored-by: Starbeamrainbowlabs <[email protected]>
@marchersimon marchersimon marked this pull request as ready for review May 16, 2021 12:59
@CleanMachine1 CleanMachine1 self-requested a review May 24, 2021 21:20
Co-authored-by: Axel Navarro <[email protected]>
Copy link
Member

@CleanMachine1 CleanMachine1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Says my review is required so here.

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @marchersimon!

Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor comment.

Co-authored-by: Owen Voke <[email protected]>
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great reference to refer people to when reviewing PRs!

@marchersimon marchersimon requested a review from bl-ue June 11, 2021 15:06
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bl-ue
Copy link
Contributor

bl-ue commented Jun 23, 2021

@SethFalco care to give this PR a review? If not, we can merge.

Copy link
Member

@SethFalco SethFalco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're using title case for the h1 at the top, but then sentence case for the h2s?
It feels a bit inconsistent for me, any opinions? (More Info)

Some changes are subjective, so don't be afraid to dispute them.

The only one I'm somewhat firm on would be the 28 syllable clause. Try reading all of that in one breath!

@CleanMachine1
Copy link
Member

CleanMachine1 commented Jun 29, 2021

Could the image(s) be made into a dark theme instead of light. How many people use dimmed/dark over black on white

@SethFalco
Copy link
Member

Could the image(s) be made into a dark theme instead of light. How many people use dimmed/dark over black on white

To be honest, I find it unlikely that most use dark mode.
I think the default theme is best for the images.

I assume that'd be light theme, or system preferences. (But all major operating systems default to light, anyway.)

@CleanMachine1
Copy link
Member

Its not a big deal. I'm fine with "default settings" being used.

@marchersimon
Copy link
Collaborator Author

I originally used dark theme, but @ bl-ue suggested to use the default one here. I understand the decision even tough a dark image in light mode isn't as bad as a light image in dark mode.

@marchersimon
Copy link
Collaborator Author

Merging, since there are already 5 approvals

@marchersimon marchersimon merged commit f2ebffb into tldr-pages:main Jun 29, 2021
@marchersimon marchersimon deleted the git-terminal-guide branch June 29, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues/PRs modifying the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants