Skip to content

Release ggplot2 3.3.0 #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 5, 2020
Merged

Conversation

thomasp85
Copy link
Member

Release post for ggplot2 3.3.0 slated for feb 24.


`stage()` is definitely not something you need every day, but it does resolve a range of issues (like the one above) and it is nice to have full transparency and control over the aesthetic evaluation.

### More extensible theming
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this section, I think it would be helpful to also see an example of how code can then make use of the new theme element, just like I did in the examples to register_theme_elements(). Apart from making the example less abstract, it'll also show the use of element_render(). As much as possible, we don't want extension developers to work with the contents of the theme elements directly. We may even want to state that they should use calc_element() to access and element_render() to render the theme elements.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I didn't do this was that I didn't want to drag in the creation of a new coord etc. just for that. I think that's beyond the scope of a release post. If you really think it is necessary I can add it, though

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine if you think it's beyond the scope. In this case, maybe refer the reader to the documentation of register_theme_elements() for a complete working example.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea

Copy link
Collaborator

@batpigandme batpigandme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! What a release. I added a few suggestions (some of which can only be implemented once the pkgdown site reflects 3.3.0 as the current version). I might add something (a header even?) indicating when you start addressing developers and/or advanced users.

The last ggplot2 release was mainly a performance-oriented release. This one, on the other hand is packed with features, big and small. There is also a slew of bug-fixes, but as that make for less interesting reading, please consult the NEWS.md file for those. Further, we have now removed reshape2 from the dependencies, which further removes the indirect dependencies on plyr, stringi and stringr. We have been shaving off dependencies in ggplot2 over a range of releases, and with the removal of reshape2 we are now close to being as lean as we believe is possible.

### Rewrite of axis code
While Dewey has worked on a lot of different parts of the ggplot2 code base, the lion share has been concerned with a rewrite of the positional guide (axis) internals. While, at a high level, axes and legends are equivalent (they are both guides used for scales), this has not been true for the underlying code. With this release we have streamlined the implementation considerably, and paved the way for a full guide rewrite in a future release (guides are one of the last part waiting to be updated to ggproto). Apart from making our life as ggplot2 developers easier, the rewrite also comes with a slew of user facing improvements and features. All of this is contained in the new `guide_axis()` function that works equivalently to e.g. `guide_legend()`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
While Dewey has worked on a lot of different parts of the ggplot2 code base, the lion share has been concerned with a rewrite of the positional guide (axis) internals. While, at a high level, axes and legends are equivalent (they are both guides used for scales), this has not been true for the underlying code. With this release we have streamlined the implementation considerably, and paved the way for a full guide rewrite in a future release (guides are one of the last part waiting to be updated to ggproto). Apart from making our life as ggplot2 developers easier, the rewrite also comes with a slew of user facing improvements and features. All of this is contained in the new `guide_axis()` function that works equivalently to e.g. `guide_legend()`.
While Dewey has worked on a lot of different parts of the ggplot2 code base, the lion's share has been concerned with a rewrite of the positional-guide (axis) internals. While, at a high level, axes and legends are equivalent (they are both guides used for scales), this has not been true for the underlying code. With this release, we have streamlined the implementation considerably, and paved the way for a full guide rewrite in a future release (guides are one of the last part waiting to be updated to ggproto). Apart from making our life as ggplot2 developers easier, the rewrite also comes with a slew of user-facing improvements and features. All of this is contained in the new `guide_axis()` function that works equivalently to e.g. `guide_legend()`.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^ changed lion share to lion's share; added hyphens to compound modifiers (e.g. user facing improvements → user-facing improvements)

Also, might link to the guide_axis() function reference, once the main pkgdown site is a go.

@thomasp85 thomasp85 requested a review from batpigandme January 13, 2020 08:44
@thomasp85
Copy link
Member Author

@batpigandme can you give it a quick run-down again as I have updated the post with inputs from you and Hadley

@thomasp85 thomasp85 merged commit 010142f into tidyverse:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants