Make inline(never) attributes more idiomatic #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@polyfractal Awesome, thanks for the PR. The inner attribute syntax has changed recently (0.10 release). This changes the previous inner attributes |
thehydroimpulse
added a commit
that referenced
this pull request
Apr 24, 2014
Make inline(never) attributes more idiomatic
|
Ah, I see. Didn't realize there was a difference between inner and outer attributes, but a quick google says that there is :) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised :)
Curious, why did the old code have
# ? I scoured the manual and don't see any mention of the exclamation mark.Is this just a relic of older syntax?