-
Notifications
You must be signed in to change notification settings - Fork 232
test: Update tests to be compatible with Jest 27 #639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/* eslint-disable @typescript-eslint/no-var-requires */ | ||
import { ReactHooksRenderer } from '../types/react' | ||
|
||
describe('default renderer', () => { | ||
beforeEach(() => { | ||
jest.resetModules() | ||
}) | ||
|
||
test('should resolve native renderer as default renderer', () => { | ||
const expectedRenderer = require('../native/pure') as ReactHooksRenderer | ||
const actualRenderer = require('../pure') as ReactHooksRenderer | ||
|
||
expect(actualRenderer).toEqual(expectedRenderer) | ||
}) | ||
|
||
test('should resolve dom renderer as default renderer', () => { | ||
jest.doMock('react-test-renderer', () => { | ||
throw new Error('missing dependency') | ||
}) | ||
|
||
const expectedRenderer = require('../dom/pure') as ReactHooksRenderer | ||
const actualRenderer = require('../pure') as ReactHooksRenderer | ||
|
||
expect(actualRenderer).toEqual(expectedRenderer) | ||
}) | ||
|
||
test('should throw error if a default renderer cannot be resolved', () => { | ||
jest.doMock('react-test-renderer', () => { | ||
throw new Error('missing dependency') | ||
}) | ||
|
||
jest.doMock('react-dom', () => { | ||
throw new Error('missing dependency') | ||
}) | ||
|
||
const expectedMessage = | ||
"Could not auto-detect a React renderer. Are you sure you've installed one of the following\n - react-dom\n - react-test-renderer\nIf you are using a bundler, please update your imports to use a specific renderer.\nFor instructions see: https://react-hooks-testing-library.com/installation#being-specific" | ||
|
||
expect(() => require('../pure')).toThrowError(new Error(expectedMessage)) | ||
}) | ||
}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,41 +1,8 @@ | ||
/* eslint-disable @typescript-eslint/no-var-requires */ | ||
import { ReactHooksRenderer } from '../types/react' | ||
import * as actualRenderer from '..' | ||
import * as expectedRenderer from '../native' | ||
|
||
describe('default renderer', () => { | ||
beforeEach(() => { | ||
jest.resetModules() | ||
}) | ||
|
||
test('should resolve native renderer as default renderer', () => { | ||
const expectedRenderer = require('../native/pure') as ReactHooksRenderer | ||
const actualRenderer = require('..') as ReactHooksRenderer | ||
|
||
expect(actualRenderer).toEqual(expectedRenderer) | ||
}) | ||
|
||
test('should resolve dom renderer as default renderer', () => { | ||
jest.doMock('react-test-renderer', () => { | ||
throw new Error('missing dependency') | ||
}) | ||
|
||
const expectedRenderer = require('../dom/pure') as ReactHooksRenderer | ||
const actualRenderer = require('..') as ReactHooksRenderer | ||
|
||
expect(actualRenderer).toEqual(expectedRenderer) | ||
}) | ||
|
||
test('should throw error if a default renderer cannot be resolved', () => { | ||
jest.doMock('react-test-renderer', () => { | ||
throw new Error('missing dependency') | ||
}) | ||
|
||
jest.doMock('react-dom', () => { | ||
throw new Error('missing dependency') | ||
}) | ||
|
||
const expectedMessage = | ||
"Could not auto-detect a React renderer. Are you sure you've installed one of the following\n - react-dom\n - react-test-renderer\nIf you are using a bundler, please update your imports to use a specific renderer.\nFor instructions see: https://react-hooks-testing-library.com/installation#being-specific" | ||
|
||
expect(() => require('..')).toThrowError(new Error(expectedMessage)) | ||
}) | ||
}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was the only test where I felt the
require
s in the tests were still appropriate. I worked around the issue by changing to use thepure
imports instead. This left the non-pure
import uncovered, which is why I introduced the simplified test file for it.