-
Notifications
You must be signed in to change notification settings - Fork 233
Convert to TypeScript #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 45 commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
b7c28dc
Added tsconfig.json. Modified eslint config
nobrayner a7b9412
Convert src/cleanup.js to TypeScript
nobrayner cdfca10
Change src/cleanup.ts to use inline types
nobrayner 5e5a248
revert eslintrc
merodiro 07278d0
disable eslint for cleanup import
merodiro e8b9dae
convert index to typescript
merodiro bc2a6c3
Worked on typing asyncUtils. Removed deprecated wait. Disabled import…
juhanakristian f58e7f0
Fix incorrect cleanup callback type
nobrayner a8ece29
asyncUtils has been updated. Two lines are disabled for eslint.
tigerabrodi 7e45893
remove unnecessary eslint disable
merodiro b8ddea3
Prettier was stripping try catch types
JacobMGEvans 4445273
Type for callback handle generic input & undefined handled by nullish…
JacobMGEvans 05e9a38
comments for review
JacobMGEvans 6879cfd
VoidFunction in place for void until decided behavior for waitFor()
JacobMGEvans 8f902ea
Utilizing OR operator with generic Types allows for desired behavior …
JacobMGEvans 2c2908b
mistakenly left out linter ignores in last commit
JacobMGEvans 58b9b37
Minimum types started for Pure file
JacobMGEvans 4818ced
removed comments -- answered in PR
JacobMGEvans 4c8d1e2
Generic HTML types for initialProps
JacobMGEvans 3f9d853
Generic HTML types for initialProps
JacobMGEvans d2dadf5
Generic type for callback and initialProps
JacobMGEvans 1dba932
Generics added and CB toplevel same generic pattern added
JacobMGEvans 6b19d1b
force rebuild with unbound method eslint ignore
JacobMGEvans 9604dd7
parser issue -- attempt to fix by removing specific TS eslint rule
JacobMGEvans b84a0de
Newer versions of ESLint might resolve the parser issue
JacobMGEvans 319cbba
Added configs to get started on test conversion
JacobMGEvans ec18c2a
Generic type for resultContainer
merodiro 7c8ddee
convert tests that require no changes
merodiro e3ecb24
add types to cleanup test
merodiro d74e947
Test TS Overhaul
JacobMGEvans d85fb85
Amr updated types useEffect
JacobMGEvans ce60735
Jens suggestion for more generic number key type
JacobMGEvans 74793cd
Remove wait reference from docs
nobrayner acfed0d
Add nobrayner to contributors
nobrayner b77b17a
Add JacobMGEvans to contributors
nobrayner b5977f6
Update src/pure.tsx
JacobMGEvans e6997ca
Add tigerabrodi to contributors
nobrayner 3485a02
Add Amr, Juhana, and Jens to contributors
nobrayner ed2bb4a
update suspenseHook, cache type and the type of the error in catch.
tigerabrodi 65e4d0c
cleanup.ts, update the way addCleanup adds another callback to cleanu…
tigerabrodi d51ddc1
Made generics more descriptive, made TestHook generic
nobrayner fb93f4e
Remove some eslint disables that didn't do anything
nobrayner 1779a85
Remove DefinitelyTyped reference in CONTRIBUTING.md
nobrayner 78c146e
chore: disable declaration for tests
marcosvega91 9d957ba
Removes createTimeoutError. Adds constructor to TimeoutError. Adds ty…
juhanakristian d1c36bd
Remove conditional in TestHook for hookProps
mpeyper 21a1c6e
Replace old types defs with referenced types in dependencies
mpeyper d621cda
Remove destructuring of `testRenderer`
mpeyper 900e89c
Disabled floating promise lint rule globally
mpeyper 4ead36f
Refactor TestHook catch to not disable lint rules
mpeyper 25509ba
Disabled eslint error for while(true)
mpeyper db8a6f3
Cleaned up some line warnings from tests
mpeyper f0d080e
Added "typecheck" kcd-script to improve "validate" script
mpeyper 84a40ad
Clean up ThrowError type in errorHook tests
mpeyper f33e457
Replace VoidFunction with () => void
mpeyper a5754f2
Replace CallableFunction with a more explicit function type
mpeyper File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,14 @@ | ||
{ | ||
"extends": "./node_modules/kcd-scripts/eslint.js", | ||
"extends": ["./node_modules/kcd-scripts/eslint.js"], | ||
"rules": { | ||
"max-lines-per-function": "off", | ||
"no-constant-condition": "off", | ||
"no-await-in-loop": "off", | ||
"react-hooks/rules-of-hooks": "off", | ||
"no-console": "off" | ||
"no-console": "off", | ||
"import/no-unresolved": "off" | ||
}, | ||
"parserOptions": { | ||
"project": ["./tsconfig.json", "./test/tsconfig.json"] | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
// eslint-disable-next-line | ||
const { jest: jestConfig } = require('kcd-scripts/config') | ||
|
||
module.exports = Object.assign(jestConfig, { | ||
roots: ['<rootDir>/src', '<rootDir>/test'], | ||
testMatch: ['<rootDir>/test/*.js'] | ||
testMatch: ['<rootDir>/test/*.(ts|tsx|js)'] | ||
}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.