Skip to content

Pr/rhtl 456 #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2020
Merged

Pr/rhtl 456 #494

merged 2 commits into from
Dec 3, 2020

Conversation

joshuaellis
Copy link
Member

What:

Fixing #456 by editting the docs to the first suggestion which I believe makes the clearest sense.

Why:

Because the English made little sense before.

How:

By updated the .md file

Checklist:

  • Documentation updated
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #494 (c0ad408) into master (77feeec) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #494   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          109       109           
  Branches        19        19           
=========================================
  Hits           109       109           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77feeec...c0ad408. Read the comment docs.

@mpeyper
Copy link
Member

mpeyper commented Dec 3, 2020

Thanks 😄

@mpeyper mpeyper merged commit 91ba499 into testing-library:master Dec 3, 2020
@joshuaellis joshuaellis deleted the pr/RHTL-456 branch December 3, 2020 13:35
@github-actions
Copy link

github-actions bot commented Dec 6, 2020

🎉 This PR is included in version 3.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants