fix(no-wait-for-side-effects): detect await expressions #1008
+30
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StyleShit
force-pushed
the
fix/742-get-property-identifier-node-await-expression
branch
from
87f42ea to
bb3ced4
Compare
StyleShit
changed the title
no-wait-for-side-effects doesn't detect await expressionno-wait-for-side-effects doesn't detect await expressions
StyleShit
commented
May 15, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1008 +/- ##
==========================================
- Coverage 96.27% 96.25% -0.03%
==========================================
Files 46 47 +1
Lines 2472 2483 +11
Branches 1025 1031 +6
==========================================
+ Hits 2380 2390 +10
- Misses 92 93 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Belco90
requested changes
May 16, 2025
There was a problem hiding this comment.
Thanks for addressing this bug!
I see code coverage went down, so Codecov complains. Can you add extra tests for no-wait-for-multiple-assertions? It's indirectly affected (see more details).
| @@ -797,5 +807,19 @@ ruleTester.run(RULE_NAME, rule, { | |||
| ], | |||
| } as const, | |||
| ]), | |||
|
|
|||
| ...SUPPORTED_TESTING_FRAMEWORKS.flatMap((testingFramework) => [ | |||
There was a problem hiding this comment.
suggestion (blocking): Please add a test for the scenario reported in #742 description.
Belco90
changed the title
no-wait-for-side-effects doesn't detect await expressions…property-identifier-node-await-expression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #742