Skip to content

feat: update browserslist and remove overrides workaround #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat: update browserslist and remove overrides workaround #1257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 17 additions & 20 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,22 +24,25 @@
"node": ">=18"
},
"browserslist": [
"and_chr 103",
"and_ff 101",
"and_qq 10.4",
"and_uc 12.12",
"android 103",
"chrome 102",
"edge 102",
"firefox 91",
"ios_saf 12.2-12.5",
"and_chr 109",
"and_ff 109",
"and_qq 13.1",
"and_uc 13.4",
"android 109",
"chrome 108",
"edge 108",
"firefox 102",
"ios_saf 16.0",
"ios_saf 15.6",
"ios_saf 14.5-14.8",
"kaios 2.5",
"op_mini all",
"op_mob 64",
"opera 88",
"safari 15.5",
"samsung 17.0",
"samsung 16.0",
"op_mob 73",
"opera 94",
"safari 16.2",
"safari 15.6",
"samsung 19.0",
"samsung 18.0",
"node 18.0"
],
"scripts": {
Expand Down Expand Up @@ -70,19 +73,13 @@
},
"devDependencies": {
"@testing-library/jest-dom": "^5.11.6",
"browserslist": "4.21.8",
"caniuse-lite": "1.0.30001502",
Comment on lines -73 to -74
Copy link
Member

@nickserv nickserv Sep 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be reverted #1257 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just a "hack" to make node 14 build pass but it didn't work so I think either way we won't need it.

"jest-in-case": "^1.0.2",
"jest-snapshot-serializer-ansi": "^1.0.0",
"jest-watch-select-projects": "^2.0.0",
"jsdom": "20.0.0",
"kcd-scripts": "^13.0.0",
"typescript": "^4.1.2"
},
"overrides": {
"browserslist": "4.21.8",
"caniuse-lite": "1.0.30001502"
},
Copy link
Member

@nickserv nickserv Sep 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be reverted #1257 (comment)

"eslintConfig": {
"extends": [
"./node_modules/kcd-scripts/eslint.js",
Expand Down