Skip to content

fix: Bump dom-accessibility-api #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2021
Merged

fix: Bump dom-accessibility-api #1063

merged 1 commit into from
Oct 18, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Oct 18, 2021

What:

Closes #1059

Why:

To support

test("Menu labbelled by button", () => {
  render(
    <>
      <button id="trigger">Test</button>
      <ul role="menu" aria-labelledby="trigger">
        <li role="menuitem">Item 1</li>
        <li role="menuitem">Item 2</li>
      </ul>
    </>
  );

  expect(screen.getByRole("menu", { name: "Test" })).toBeInTheDocument();
});

How:

Bump dom-accessibility-api to 0.5.9 to pull in eps1lon/dom-accessibility-api#762

Checklist:

@eps1lon eps1lon added the bug Something isn't working label Oct 18, 2021
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1ce141b:

Sandbox Source
react-testing-library-examples Configuration
ByRole-menu (forked) Issue #1059
ByRole-menu (forked) Issue #1059

@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #1063 (1ce141b) into main (b9ae752) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1063   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines          952       952           
  Branches       311       311           
=========================================
  Hits           952       952           
Flag Coverage Δ
node-12 100.00% <ø> (ø)
node-14 100.00% <ø> (ø)
node-16.9.1 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9ae752...1ce141b. Read the comment docs.

@eps1lon eps1lon marked this pull request as ready for review October 18, 2021 13:55
@eps1lon eps1lon merged commit b6b9b5b into main Oct 18, 2021
@eps1lon eps1lon deleted the eps1lon-patch-1 branch October 18, 2021 13:55
@github-actions
Copy link

🎉 This PR is included in version 8.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

MatthiasKainer pushed a commit to MatthiasKainer/dom-testing-library that referenced this pull request Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

*ByRole doesn't work for the menu role
1 participant