Bump webtesting rules and uses versioned browser for tests. #6772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bazel web testing rules package provides versioned browsers for testing. The one from 0.3.3 was picked somewhat arbitrarily as it seems old enough to provide enough compatibility coverage, without being as old as the version we were using before. This change might produce some scuba tests to be updated. Alternatively, we can accomplish the same result we had before with our custom browser, but some of the rules that we use for this purpose have been removed/changed. In that case, we'd need to use the `platform_archive` rule, like they do [here] (https://github.com/bazelbuild/rules_webtesting/blob/9e9361ba887a3b687f537c02409b690b62fecdfe/web/versioned/browsers-0.3.3.bzl#L134), and then define a browser similarly like they do [here] (https://github.com/bazelbuild/rules_webtesting/blob/9e9361ba887a3b687f537c02409b690b62fecdfe/browsers/BUILD.bazel#L50), which in turn declares a dependency on [this file] (https://github.com/bazelbuild/rules_webtesting/blob/9e9361ba887a3b687f537c02409b690b62fecdfe/third_party/chromium/BUILD.bazel), which is the one that references the output from the `platform_archive` rule.
…ixes formatting issues.
arcra
added a commit
to arcra/tensorboard
that referenced
this pull request
Mar 5, 2024
We haven't updated this dependency on the bazel webtesting rules for a while, and it looks like we need to do it to be able to also update our reference to the rules_closure target, to unblock tensorflow#6721. To be clear, this PR is a prerequisite to pin the rules_closure version in a separate PR, which in turn will unblock tensorflow#6721. An attempt to use the versioned browsers provided by the rules_webtesting dependency was created in tensorflow#6772, but some tests were failing. It seems that some components or tests were written in a way that depends on the specific browser (?), so to be able to update this dependency, this continues to use the same browser version, only updating the rules we use to define our testing browser, to be compatible with a newer version of rules_webtesting.
arcra
added a commit
that referenced
this pull request
Mar 5, 2024
We haven't updated this dependency on the bazel webtesting rules for a while, and it looks like we need to do it to be able to also update our reference to the rules_closure target, to unblock #6721. To be clear, this PR is a prerequisite to pin the rules_closure version in a separate PR, which in turn will unblock #6721. (Or at least that's the expectation. It is yet to be confirmed that the rules_closure version we want to pin is compatible with this one). An attempt to use the versioned browsers provided by the rules_webtesting dependency was created in #6772, but some tests were failing. It seems that some components or tests were written in a way that depends on the specific browser (?), so to be able to update this dependency, this continues to use the same browser version, only updating the rules we use to define our testing browser, to be compatible with a newer version of rules_webtesting.
AnuarTB
pushed a commit
to AnuarTB/tensorboard
that referenced
this pull request
May 3, 2024
We haven't updated this dependency on the bazel webtesting rules for a while, and it looks like we need to do it to be able to also update our reference to the rules_closure target, to unblock tensorflow#6721. To be clear, this PR is a prerequisite to pin the rules_closure version in a separate PR, which in turn will unblock tensorflow#6721. (Or at least that's the expectation. It is yet to be confirmed that the rules_closure version we want to pin is compatible with this one). An attempt to use the versioned browsers provided by the rules_webtesting dependency was created in tensorflow#6772, but some tests were failing. It seems that some components or tests were written in a way that depends on the specific browser (?), so to be able to update this dependency, this continues to use the same browser version, only updating the rules we use to define our testing browser, to be compatible with a newer version of rules_webtesting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bazel web testing rules package provides versioned browsers for testing, which should be easier for us to update/maintain than using additional rules to define our own browser.
The one from 0.3.3 was picked somewhat arbitrarily as it seems old enough to provide enough compatibility coverage, without being as old as the version we were using before.
This change might produce some scuba tests to be updated.
Alternatively, we can accomplish the same result we had before with our custom browser, but some of the rules that we use for this purpose have been removed/changed.
In that case, we'd need to use the
platform_archiverule, like they do here, and then define a browser similarly like they do here, which in turn declares a dependency on this file, which is the one that references the output from theplatform_archiverule.