Introduce lint

.codespellrc

@@ -0,0 +1,3 @@
+[codespell]
+skip = tarantool/msgpack_ext/types/timezones/timezones.py
+ignore-words-list = ans,gost,ro

.flake8

@@ -0,0 +1,3 @@
+[flake8]
+# Use pylint for lines length check
+ignore=E501,W503

.github/workflows/testing.yml

@@ -37,7 +37,7 @@ jobs:
           - ''
 
         # Adding too many elements to three-dimentional matrix results in
-        # too many test cases. It causes GitHub webpages to fail with 
+        # too many test cases. It causes GitHub webpages to fail with
         # "This page is taking too long to load." error. Thus we use
         # pairwise testing.
         include:

.pylintrc

@@ -0,0 +1,8 @@
+[BASIC]
+
+# Good variable names which should always be accepted, separated by a comma
+good-names=i,j,k,ex,Run,_,ok,t,tz
+
+[FORMAT]
+# Allow links in docstings, allow tables
+ignore-long-lines=^(?:\s*(# )?(?:\.\.\s.+?:)?\s*<?https?://\S+>?)|(\s\+.+\+)|(\s\|.+\|)$

CHANGELOG.md

@@ -4,10 +4,18 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## Unreleased
+
+### Changed
+- **Breaking**: Allow only named `on_push` and `on_push_ctx` for `insert` and `replace`.
+- Migrate to built-in `Warning` instead of a custom one.
+- Migrate to built-in `RecursionError` instead of a custom one.
+- Collect full exception traceback.
+
 ## 0.12.1 - 2023-02-28
 
 ### Changed
-- Discovery iproto features only for Tarantools since version 2.10.0 (#283). 
+- Discovery iproto features only for Tarantools since version 2.10.0 (#283).
 
 ### Fixed
 - Schema fetch for spaces with foreign keys (#282).
@@ -352,7 +360,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Various improvements and fixes in README (PR #210, PR #215).
 
 ### Fixed
-- json.dumps compatibility with Python 2 (PR #186). 
+- json.dumps compatibility with Python 2 (PR #186).
 - Unix socket support in mesh_connection (PR #189, #111).
 - Various fixes in tests (PR #189, #111, PR #195, #194).
 

Makefile

@@ -3,8 +3,17 @@ install:
 	pip3 install --editable .
 
 
+PYTHON_FILES=tarantool test setup.py docs/source/conf.py
+TEXT_FILES=README.rst docs/source/*.rst
+.PHONY: lint
+lint:
+	python3 -m pylint --recursive=y $(PYTHON_FILES)
+	python3 -m flake8 $(PYTHON_FILES)
+	codespell $(PYTHON_FILES) $(TEXT_FILES)
+
+
 .PHONY: test
-test:
+test: lint
 	python3 setup.py test
 
 .PHONY: test-pure-install

README.rst

@@ -86,7 +86,7 @@ You can also install the development version of the package using ``pip``.
 What is Tarantool?
 ------------------
 
-`Tarantool`_ is an in-memory computing platform originally designed by 
+`Tarantool`_ is an in-memory computing platform originally designed by
 `VK`_ and released under the terms of `BSD license`_.
 
 Features

debian/changelog

@@ -290,7 +290,7 @@ tarantool-python (0.9.0-0) unstable; urgency=medium
         transport="ssl",
         ssl_ca_file=client_ca_file)
     ```
-    
+
     If the server authenticates clients using certificates issued by
     given CA, you must provide private SSL key file with `ssl_key_file`
     parameter and SSL certificate file with `ssl_cert_file` parameter.
@@ -351,7 +351,7 @@ tarantool-python (0.9.0-0) unstable; urgency=medium
     ```
 
     See [Tarantool Enterprise Edition manual](https://www.tarantool.io/en/enterprise_doc/security/#enterprise-iproto-encryption)
-    for details. 
+    for details.
 
     ## Breaking changes
 

debian/rules

@@ -14,7 +14,7 @@ override_dh_auto_build:
 	python3 setup.py build --force
 
 override_dh_auto_install:
-	python3 setup.py install --force --root=debian/python3-tarantool --no-compile -O0 --install-layout=deb --prefix=/usr 
+	python3 setup.py install --force --root=debian/python3-tarantool --no-compile -O0 --install-layout=deb --prefix=/usr
 
 override_dh_python2:
 	dh_python2 --no-guessing-versions

docs/source/conf.py

@@ -1,15 +1,19 @@
-# Tarantool python client library documentation build configuration file, created by
-# sphinx-quickstart on Tue Nov 29 06:29:57 2011.
-#
-# This file is execfile()d with the current directory set to its containing dir.
-#
-# Note that not all possible configuration values are present in this
-# autogenerated file.
-#
-# All configuration values have a default; values that are commented out
-# serve to show the default.
-
-import sys, os
+"""
+Tarantool python client library documentation build configuration file, created by
+sphinx-quickstart on Tue Nov 29 06:29:57 2011.
+
+This file is execfile()d with the current directory set to its containing dir.
+
+Note that not all possible configuration values are present in this
+autogenerated file.
+
+All configuration values have a default; values that are commented out
+serve to show the default.
+"""
+# pylint: disable=invalid-name,redefined-builtin,duplicate-code
+# flake8: noqa: E265
+
+import tarantool
 
 # If extensions (or modules to document with autodoc) are in another directory,
 # add these directories to sys.path here. If the directory is relative to the
@@ -45,15 +49,13 @@
 master_doc = 'index'
 
 # General information about the project.
-project = u'Tarantool python client library'
-copyright = u'2011-2022, tarantool-python AUTHORS'
+project = 'Tarantool python client library'
+copyright = '2011-2022, tarantool-python AUTHORS'
 
 # The version info for the project you're documenting, acts as replacement for
 # |version| and |release|, also used in various other places throughout the
 # built documents.
 
-import tarantool
-
 # The short X.Y version.
 version = tarantool.__version__
 # The full version, including alpha/beta/rc tags.
@@ -126,7 +128,7 @@
 # pixels large.
 #html_favicon = None
 
-# Set up favicons with sphinx_favicon. 
+# Set up favicons with sphinx_favicon.
 favicons = [
     {
         "rel": "icon",
@@ -279,8 +281,8 @@
 # Grouping the document tree into LaTeX files. List of tuples
 # (source start file, target name, title, author, documentclass [howto/manual]).
 latex_documents = [
-  ('index', 'Tarantoolpythonclientlibrary.tex', u'Tarantool python client library Documentation',
-   u'tarantool-python AUTHORS', 'manual'),
+  ('index', 'Tarantoolpythonclientlibrary.tex', 'Tarantool python client library Documentation',
+   'tarantool-python AUTHORS', 'manual'),
 ]
 
 # The name of an image file (relative to this directory) to place at the top of
@@ -309,8 +311,8 @@
 # One entry per manual page. List of tuples
 # (source start file, name, description, authors, manual section).
 man_pages = [
-    ('index', 'tarantoolpythonclientlibrary', u'Tarantool python client library Documentation',
-     [u'tarantool-python AUTHORS'], 1)
+    ('index', 'tarantoolpythonclientlibrary', 'Tarantool python client library Documentation',
+     ['tarantool-python AUTHORS'], 1)
 ]
 
 # If true, show URL addresses after external links.
@@ -323,8 +325,8 @@
 # (source start file, target name, title, author,
 #  dir menu entry, description, category)
 texinfo_documents = [
-  ('index', 'Tarantoolpythonclientlibrary', u'Tarantool python client library Documentation',
-   u'tarantool-python AUTHORS', 'Tarantoolpythonclientlibrary', 'One line description of project.',
+  ('index', 'Tarantoolpythonclientlibrary', 'Tarantool python client library Documentation',
+   'tarantool-python AUTHORS', 'Tarantoolpythonclientlibrary', 'One line description of project.',
    'Miscellaneous'),
 ]
 

docs/source/index.rst

@@ -5,7 +5,7 @@ Python client library for Tarantool
 
 :Version: |version|
 
-`Tarantool`_ is an in-memory computing platform originally designed by 
+`Tarantool`_ is an in-memory computing platform originally designed by
 `VK`_ and released under the terms of `BSD license`_.
 
 Install Tarantool Python connector with ``pip`` (`PyPI`_ page):
@@ -78,7 +78,7 @@ API Reference
 
 .. Indices and tables
 .. ==================
-.. 
+..
 .. * :ref:`genindex`
 .. * :ref:`modindex`
 .. * :ref:`search`