Skip to content

feature: acquire exact tarantool version #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

Totktonada
Copy link
Member

@Totktonada Totktonada commented Feb 10, 2022

Sometimes we want to test a module against specific tarantool version,
not a latest in the series. For example, 2.6 series may have 2.6.1,
2.6.2 and 2.6.3 releases and we want to setup 2.6.1.

Fixes #15


Usage examples:

steps:
  - uses: actions/checkout@v2
  - uses: tarantool/setup-tarantool@v1
    with:
      tarantool-version: '2.8.1'

(Before the patch we can only choose tarantool-version: '2.8' and the latest version in the 2.8 series (2.8.4) would be installed. Now we can choose one of previous versions in the series.)

steps:
  - uses: actions/checkout@v2
  - uses: tarantool/setup-tarantool@v1
    with:
      tarantool-version: '1.10.13.23'
      nightly-build: true

(We can also write tarantool-version: '1.10.13' to install the latest nightly build of 1.10.13 -- it is 1.10.13.23 at the moment of writing.)

@Totktonada Totktonada marked this pull request as draft February 10, 2022 22:45
@Totktonada Totktonada force-pushed the Totktonada/gh-15-choose-exact-release branch from 679ae6b to 427786e Compare February 11, 2022 13:29
@Totktonada Totktonada force-pushed the Totktonada/gh-15-choose-exact-release branch from 7b61114 to b82932a Compare June 22, 2022 00:45
@Totktonada Totktonada changed the title WIP: feature: acquire exact tarantool version feature: acquire exact tarantool version Jun 22, 2022
@Totktonada Totktonada marked this pull request as ready for review June 22, 2022 08:04
@Totktonada
Copy link
Member Author

Tested on tarantool/smtp: tarantool/smtp@20b2404.

Copy link
Member

@DifferentialOrange DifferentialOrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, TypeScript part seems easy to understand even for a first-timer, but GH Actions part left me a bit confused. I have left a couple of questions, but if I got it right this PR should be ok

@Totktonada Totktonada force-pushed the Totktonada/gh-15-choose-exact-release branch from b82932a to 8eab8b3 Compare June 23, 2022 16:11
Sometimes we want to test a module against specific tarantool version,
not a latest in the series. For example, 2.6 series may have 2.6.1,
2.6.2 and 2.6.3 releases and we want to setup 2.6.1.

Fixes #15
@Totktonada Totktonada force-pushed the Totktonada/gh-15-choose-exact-release branch from 8eab8b3 to e360a74 Compare June 23, 2022 16:43
@Totktonada Totktonada merged commit e1bb39f into master Jun 23, 2022
@Totktonada Totktonada deleted the Totktonada/gh-15-choose-exact-release branch June 23, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choose exact release (such as 2.5.1)
2 participants