forked from fl00r/go-tarantool-1.6
-
Notifications
You must be signed in to change notification settings - Fork 60
Test fails with Tarantool 2.8.1 or newer #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
bug
Something isn't working
Comments
It seems there were copy-paste error from the beginning (11 != 10):
Or there should be two inserts: with error on duplicate and new one. There is no need too make "fork". Just change |
This bug blocks resolving the issue tarantool/tarantool#6607. So we need to fix it ASAP. |
DifferentialOrange
added a commit
that referenced
this issue
Nov 15, 2021
DifferentialOrange
added a commit
that referenced
this issue
Nov 15, 2021
Based on code comments and @funny-falcon response in #105, the test has been planned to be success insert test and not a duplicate key error test. I changed test case and asserts based on this information. Since duplicate key test already exists in tarantool_test.go file [1], coverage should not decrease. 1. https://github.com/tarantool/go-tarantool/blob/61f3a41907b6bcb060e9fa07069cde5b33ba9764/tarantool_test.go#L437-L443 Closes #105
DifferentialOrange
added a commit
that referenced
this issue
Nov 15, 2021
Original test case had failed with Tarantool 2.8.1 or newer due to error message rework [1]. Based on code comments and @funny-falcon response in #105, the test has been planned to be success insert test and not a duplicate key error test. This patch changes test case and asserts to its original idea. Since duplicate key test already exists in tarantool_test.go file [2], coverage should not decrease. 1. tarantool/tarantool@d11fb30 2. https://github.com/tarantool/go-tarantool/blob/61f3a41907b6bcb060e9fa07069cde5b33ba9764/tarantool_test.go#L437-L443 Closes #105
oleg-jukovec
added a commit
that referenced
this issue
Jun 1, 2022
Overview This release adds a number of features and updates documentation. Breaking changes There are no breaking changes in the release. New features Coveralls support (#149). Reusable testing workflow (integration testing with latest Tarantool) (#123). Simple CI based on GitHub actions (#114). Support UUID type in msgpack (#90). Go modules support (#91). queue-utube handling (#85). Master discovery (#113). SQL support (#62). Handle everything with `go test` (#115). Update API documentation: comments and examples (#123). Bugfixes Reset buffer if its average use size smaller than quater of capacity (#95). Fix queue tests (#107). Make test case consistent with comments (#105).
oleg-jukovec
added a commit
that referenced
this issue
Jun 1, 2022
Overview This release adds a number of features and updates documentation. Breaking changes There are no breaking changes in the release. New features Coveralls support (#149). Reusable testing workflow (integration testing with latest Tarantool) (#123). Simple CI based on GitHub actions (#114). Support UUID type in msgpack (#90). Go modules support (#91). queue-utube handling (#85). Master discovery (#113). SQL support (#62). Handle everything with `go test` (#115). Update API documentation: comments and examples (#123). Bugfixes Reset buffer if its average use size smaller than quater of capacity (#95). Fix queue tests (#107). Make test case consistent with comments (#105).
oleg-jukovec
added a commit
that referenced
this issue
Jun 1, 2022
Overview This release adds a number of features and updates documentation. Breaking changes There are no breaking changes in the release. New features Coveralls support (#149). Reusable testing workflow (integration testing with latest Tarantool) (#123). Simple CI based on GitHub actions (#114). Support UUID type in msgpack (#90). Go modules support (#91). queue-utube handling (#85). Master discovery (#113). SQL support (#62). Handle everything with `go test` (#115). Update API documentation: comments and examples (#123). Bugfixes Reset buffer if its average use size smaller than quater of capacity (#95). Fix queue tests (#107). Make test case consistent with comments (#105).
Merged
oleg-jukovec
added a commit
that referenced
this issue
Jun 1, 2022
Overview This release adds a number of features and updates documentation. Breaking changes There are no breaking changes in the release. New features Coveralls support (#149). Reusable testing workflow (integration testing with latest Tarantool) (#112). Simple CI based on GitHub actions (#114). Support UUID type in msgpack (#90). Go modules support (#91). queue-utube handling (#85). Master discovery (#113). SQL support (#62). Handle everything with `go test` (#115). Update API documentation: comments and examples (#123). Bugfixes Reset buffer if its average use size smaller than quater of capacity (#95). Fix queue tests (#107). Make test case consistent with comments (#105).
oleg-jukovec
added a commit
that referenced
this issue
Jun 2, 2022
Overview This release adds a number of features. Also it significantly improves testing, CI and documentation. Breaking changes There are no breaking changes in the release. New features Support UUID type in msgpack (#90). queue-utube handling (#85). Master discovery (#113). SQL support (#62). Bugfixes Reset buffer if its average use size smaller than quater of capacity (#95). Testing Coveralls support (#149). Reusable testing workflow (integration testing with latest Tarantool) (#112). Simple CI based on GitHub actions (#114). Handle everything with `go test` (#115). Fix queue tests (#107). Make test case consistent with comments (#105). Other Go modules support (#91). Update API documentation: comments and examples (#123).
oleg-jukovec
added a commit
that referenced
this issue
Jun 2, 2022
Overview This release adds a number of features. Also it significantly improves testing, CI and documentation. Breaking changes There are no breaking changes in the release. New features Support UUID type in msgpack (#90). queue-utube handling (#85). Master discovery (#113). SQL support (#62). Bugfixes Reset buffer if its average use size smaller than quater of capacity (#95). Testing Coveralls support (#149). Reusable testing workflow (integration testing with latest Tarantool) (#112). Simple CI based on GitHub actions (#114). Handle everything with `go test` (#115). Fix queue tests (#107). Make test case consistent with comments (#105). Other Go modules support (#91). Update API documentation: comments and examples (#123).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This commit has changes duplicate key message in Tarantool 2.8.1. Thus test run fails in
Example()
test of example_test.go file since Tarantool returnswhile
go-tarantool/example_test.go
Line 197 in 56fe55c
is expected.
To fix tests for Tarantool 2.x (since versions prior to 2.8.2 is EOL or will be there soon), example_test.go should be rewritten with some kind of fork based on Tarantool version or test case comparison should be replaced with regex.
The text was updated successfully, but these errors were encountered: