Skip to content

Test fails with Tarantool 2.8.1 or newer #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DifferentialOrange opened this issue Nov 2, 2021 · 2 comments · Fixed by #111
Closed

Test fails with Tarantool 2.8.1 or newer #105

DifferentialOrange opened this issue Nov 2, 2021 · 2 comments · Fixed by #111
Assignees
Labels
bug Something isn't working

Comments

@DifferentialOrange
Copy link
Member

This commit has changes duplicate key message in Tarantool 2.8.1. Thus test run fails in Example() test of example_test.go file since Tarantool returns

Insert Error Duplicate key exists in unique index "primary" in space "test" with old tuple - [10, "test", "one"] and new tuple - [10, "test", "one"] (0x3)

while

// Insert Error Duplicate key exists in unique index 'primary' in space 'test' (0x3)

is expected.

To fix tests for Tarantool 2.x (since versions prior to 2.8.2 is EOL or will be there soon), example_test.go should be rewritten with some kind of fork based on Tarantool version or test case comparison should be replaced with regex.

@funny-falcon
Copy link

It seems there were copy-paste error from the beginning (11 != 10):

	// insert new tuple { 11, 1 }
	resp, err = client.Insert("test", &Tuple{Id: 10, Msg: "test", Name: "one"})

Or there should be two inserts: with error on duplicate and new one.

There is no need too make "fork". Just change fmt.Println("Insert Error", err) to something more clever.

@Totktonada Totktonada added the bug Something isn't working label Nov 9, 2021
@ylobankov
Copy link

This bug blocks resolving the issue tarantool/tarantool#6607. So we need to fix it ASAP.

@DifferentialOrange DifferentialOrange self-assigned this Nov 12, 2021
DifferentialOrange added a commit that referenced this issue Nov 15, 2021
DifferentialOrange added a commit that referenced this issue Nov 15, 2021
Based on code comments and @funny-falcon response in #105, the test has
been planned to be success insert test and not a duplicate key error
test. I changed test case and asserts based on this information. Since
duplicate key test already exists in tarantool_test.go file [1],
coverage should not decrease.

1. https://github.com/tarantool/go-tarantool/blob/61f3a41907b6bcb060e9fa07069cde5b33ba9764/tarantool_test.go#L437-L443

Closes #105
DifferentialOrange added a commit that referenced this issue Nov 15, 2021
Original test case had failed with Tarantool 2.8.1 or newer due to error
message rework [1]. Based on code comments and @funny-falcon response
in #105, the test has been planned to be success insert test and not
a duplicate key error test. This patch changes test case and asserts
to its original idea. Since duplicate key test already exists
in tarantool_test.go file [2], coverage should not decrease.

1. tarantool/tarantool@d11fb30
2. https://github.com/tarantool/go-tarantool/blob/61f3a41907b6bcb060e9fa07069cde5b33ba9764/tarantool_test.go#L437-L443

Closes #105
oleg-jukovec added a commit that referenced this issue Jun 1, 2022
Overview

This release adds a number of features and updates documentation.

Breaking changes

	There are no breaking changes in the release.

New features

	Coveralls support (#149).

	Reusable testing workflow (integration testing with latest Tarantool) (#123).

	Simple CI based on GitHub actions (#114).

	Support UUID type in msgpack (#90).

	Go modules support (#91).

	queue-utube handling (#85).

	Master discovery (#113).

	SQL support (#62).

    Handle everything with `go test` (#115).

	Update API documentation: comments and examples (#123).

Bugfixes

	Reset buffer if its average use size smaller than quater of capacity (#95).

	Fix queue tests (#107).

	Make test case consistent with comments (#105).
oleg-jukovec added a commit that referenced this issue Jun 1, 2022
Overview

This release adds a number of features and updates documentation.

Breaking changes

	There are no breaking changes in the release.

New features

	Coveralls support (#149).

	Reusable testing workflow (integration testing with latest
	Tarantool) (#123).

	Simple CI based on GitHub actions (#114).

	Support UUID type in msgpack (#90).

	Go modules support (#91).

	queue-utube handling (#85).

	Master discovery (#113).

	SQL support (#62).

    Handle everything with `go test` (#115).

	Update API documentation: comments and examples (#123).

Bugfixes

	Reset buffer if its average use size smaller than quater of
	capacity (#95).

	Fix queue tests (#107).

	Make test case consistent with comments (#105).
oleg-jukovec added a commit that referenced this issue Jun 1, 2022
Overview

This release adds a number of features and updates documentation.

Breaking changes

	There are no breaking changes in the release.

New features

	Coveralls support (#149).

	Reusable testing workflow (integration testing with latest
	Tarantool) (#123).

	Simple CI based on GitHub actions (#114).

	Support UUID type in msgpack (#90).

	Go modules support (#91).

	queue-utube handling (#85).

	Master discovery (#113).

	SQL support (#62).

	Handle everything with `go test` (#115).

	Update API documentation: comments and examples (#123).

Bugfixes

	Reset buffer if its average use size smaller than quater of
	capacity (#95).

	Fix queue tests (#107).

	Make test case consistent with comments (#105).
oleg-jukovec added a commit that referenced this issue Jun 1, 2022
Overview

This release adds a number of features and updates documentation.

Breaking changes

	There are no breaking changes in the release.

New features

	Coveralls support (#149).

	Reusable testing workflow (integration testing with latest
	Tarantool) (#112).

	Simple CI based on GitHub actions (#114).

	Support UUID type in msgpack (#90).

	Go modules support (#91).

	queue-utube handling (#85).

	Master discovery (#113).

	SQL support (#62).

	Handle everything with `go test` (#115).

	Update API documentation: comments and examples (#123).

Bugfixes

	Reset buffer if its average use size smaller than quater of
	capacity (#95).

	Fix queue tests (#107).

	Make test case consistent with comments (#105).
oleg-jukovec added a commit that referenced this issue Jun 2, 2022
Overview

This release adds a number of features. Also it significantly improves
testing, CI and documentation.

Breaking changes

    There are no breaking changes in the release.

New features

    Support UUID type in msgpack (#90).

    queue-utube handling (#85).

    Master discovery (#113).

    SQL support (#62).

Bugfixes

    Reset buffer if its average use size smaller than quater of
    capacity (#95).

Testing

    Coveralls support (#149).

    Reusable testing workflow (integration testing with latest
    Tarantool) (#112).

    Simple CI based on GitHub actions (#114).

    Handle everything with `go test` (#115).

    Fix queue tests (#107).

    Make test case consistent with comments (#105).

Other

    Go modules support (#91).

    Update API documentation: comments and examples (#123).
oleg-jukovec added a commit that referenced this issue Jun 2, 2022
Overview

This release adds a number of features. Also it significantly improves
testing, CI and documentation.

Breaking changes

    There are no breaking changes in the release.

New features

    Support UUID type in msgpack (#90).

    queue-utube handling (#85).

    Master discovery (#113).

    SQL support (#62).

Bugfixes

    Reset buffer if its average use size smaller than quater of
    capacity (#95).

Testing

    Coveralls support (#149).

    Reusable testing workflow (integration testing with latest
    Tarantool) (#112).

    Simple CI based on GitHub actions (#114).

    Handle everything with `go test` (#115).

    Fix queue tests (#107).

    Make test case consistent with comments (#105).

Other

    Go modules support (#91).

    Update API documentation: comments and examples (#123).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants