Skip to content

datetime: describe relational operators #4413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

ligurio
Copy link
Member

@ligurio ligurio commented Aug 6, 2024

Follows up commit de58780
("Add a new section for the datetime module with the description of its main functions and methods").

Datetime comparison has been added in [1] (since 2.10.0-beta2), interval comparison has been added in commit [2]
(since 2.11.0-rc1).

  1. tarantool/tarantool@43e10ed
  2. tarantool/tarantool@65a3c17

Follows up #2411
Fixes #3339

@ligurio ligurio force-pushed the ligurio/gh-3339-comparison-operators branch from 43b1af5 to 5e62fe7 Compare August 6, 2024 14:21
@ligurio ligurio requested a review from andreyaksenov August 6, 2024 14:21
Copy link
Contributor

@andreyaksenov andreyaksenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my suggestions below

@ligurio ligurio force-pushed the ligurio/gh-3339-comparison-operators branch from 74cbee9 to d8b0f20 Compare August 6, 2024 18:41
@ligurio
Copy link
Member Author

ligurio commented Aug 6, 2024

Fixed datetime objects in example:

--- a/doc/reference/reference_lua/datetime.rst
+++ b/doc/reference/reference_lua/datetime.rst
@@ -978,11 +978,11 @@ Support for relational operators for ``interval`` objects has been added since :
 
 ..  code-block:: tarantoolsession
 
-    tarantool> dt1 = datetime.now()
+    tarantool> dt1 = datetime.new { year = 2010 }
     ---
     ...
 
-    tarantool> dt2 = datetime.now()
+    tarantool> dt2 = datetime.new { year = 2024 }
     ---
     ...

@ligurio ligurio force-pushed the ligurio/gh-3339-comparison-operators branch from d8b0f20 to bbc4fca Compare August 6, 2024 18:47
Follows up commit de58780
("Add a new section for the datetime module with the description of its main functions and methods").

Datetime comparison has been added in [1] (since 2.10.0-beta2),
interval comparison has been added in commit [2]
(since 2.11.0-rc1).

1. tarantool/tarantool@43e10ed
2. tarantool/tarantool@65a3c17

Follows up #2411
Fixes #3339
@ligurio ligurio force-pushed the ligurio/gh-3339-comparison-operators branch from bbc4fca to dc191b4 Compare August 6, 2024 18:47
Copy link
Contributor

@andreyaksenov andreyaksenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@andreyaksenov andreyaksenov merged commit 31d7699 into latest Aug 7, 2024
1 check passed
@andreyaksenov andreyaksenov deleted the ligurio/gh-3339-comparison-operators branch August 7, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feedback: datetime_object | Tarantool
2 participants