Skip to content

Document join retry #3474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2023
Merged

Document join retry #3474

merged 1 commit into from
May 25, 2023

Conversation

andreyaksenov
Copy link
Contributor

@andreyaksenov andreyaksenov commented May 23, 2023

Updated topics:

Here are the main changes in replication docs:

  • Updated structure of the Replication mechanism section: split in into Replication overview, Replication stages, and Replica set and instance UUIDs subsections.
  • The Replication stages section is new and now contains information about join retry in the case of non-critical issues.
  • Added new wait_snapshot and fetch_snapshot statuses to reference. Also added some missing statuses, sorted them as they appear during connecting a replica to the master, and changed connecting to connect.

Changes that are not directly related to a new feature:

  • Added information about WAL extensions (see Replication overview).
  • Split up specifics of adding different types of information to the WAL into separate list items (see Replication overview).
  • Some minor fixes.

@andreyaksenov andreyaksenov force-pushed the 2.11-retry-join branch 3 times, most recently from 877f3f5 to efef2fd Compare May 23, 2023 13:06
@andreyaksenov andreyaksenov force-pushed the 2.11-retry-join branch 4 times, most recently from 9c78638 to c78ca39 Compare May 23, 2023 15:14
@andreyaksenov andreyaksenov linked an issue May 23, 2023 that may be closed by this pull request
@andreyaksenov andreyaksenov marked this pull request as ready for review May 24, 2023 07:09
Copy link
Contributor

@sergepetrenko sergepetrenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good now.

Copy link
Contributor

@xuniq xuniq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

**instance id**. All identifiers are stored in system space
:ref:`box.space._cluster <box_space-cluster>`. For example:
used to refer to the instance in the write-ahead log. It is called
**instance id**. All identifiers are stored in the system space
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**instance id**. All identifiers are stored in the system space
**instance ID**. All identifiers are stored in the system space

Comment on lines 138 to 139
Here ``vclock`` contains log sequence numbers (827 and 584) for instances with
instance IDs 1 and 2.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Here ``vclock`` contains log sequence numbers (827 and 584) for instances with
instance IDs 1 and 2.
Here ``vclock`` contains log sequence numbers (``827`` and ``584``) for instances with
instance IDs ``1`` and ``2``.

**replica**.
.. _replication_overview:

Replication overview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Replication overview
Overview

@andreyaksenov andreyaksenov changed the base branch from 2.11 to latest May 25, 2023 08:53
@andreyaksenov andreyaksenov changed the base branch from latest to 2.11 May 25, 2023 08:53
@andreyaksenov andreyaksenov changed the base branch from 2.11 to latest May 25, 2023 08:54
@andreyaksenov andreyaksenov merged commit 752717e into latest May 25, 2023
@andreyaksenov andreyaksenov deleted the 2.11-retry-join branch May 25, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants