Skip to content

Add box.info.ro_reason description #3170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 6, 2022
Merged

Conversation

xuniq
Copy link
Contributor

@xuniq xuniq commented Sep 28, 2022

Resolves #2445

@xuniq xuniq force-pushed the gh-2445-box-info-ro-reason branch from d105dbb to 4587f3b Compare October 3, 2022 10:33
@xuniq xuniq marked this pull request as ready for review October 3, 2022 10:35
@xuniq xuniq requested a review from Gerold103 October 3, 2022 10:41
Copy link
Contributor

@Gerold103 Gerold103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! One comment.

@xuniq xuniq force-pushed the gh-2445-box-info-ro-reason branch from 4587f3b to a6adb06 Compare October 6, 2022 09:21
@xuniq xuniq requested a review from patiencedaur October 6, 2022 10:27
Copy link
Contributor

@patiencedaur patiencedaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have a couple minor suggestions.

@xuniq xuniq force-pushed the gh-2445-box-info-ro-reason branch from 6272543 to 2733d74 Compare October 6, 2022 14:31
@xuniq xuniq merged commit 8d5d58a into latest Oct 6, 2022
@xuniq xuniq deleted the gh-2445-box-info-ro-reason branch October 6, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3pt] box.info.ro_reason
3 participants