Skip to content

Provide box.info.synchro interface #3140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 23, 2022
Merged

Provide box.info.synchro interface #3140

merged 5 commits into from
Sep 23, 2022

Conversation

xuniq
Copy link
Contributor

@xuniq xuniq commented Sep 12, 2022

@xuniq xuniq marked this pull request as draft September 12, 2022 10:43
@xuniq xuniq force-pushed the gh-2044-box-info-synchro branch from cb017c6 to 17bbb7e Compare September 15, 2022 10:27
@xuniq xuniq marked this pull request as ready for review September 15, 2022 10:41
@xuniq xuniq force-pushed the gh-2044-box-info-synchro branch from 0bea959 to 2a425df Compare September 19, 2022 09:52
@xuniq xuniq requested a review from sergepetrenko September 19, 2022 10:10
@xuniq xuniq force-pushed the gh-2044-box-info-synchro branch from 2a425df to 3282d05 Compare September 21, 2022 10:50
@xuniq xuniq requested a review from sergepetrenko September 21, 2022 10:59
Copy link
Contributor

@sergepetrenko sergepetrenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!
LGTM.

@xuniq xuniq force-pushed the gh-2044-box-info-synchro branch from 3282d05 to 5984f94 Compare September 21, 2022 16:25
@xuniq xuniq requested a review from p7nov September 22, 2022 10:11
Copy link
Contributor

@p7nov p7nov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just some remarks about the style.

@xuniq xuniq force-pushed the gh-2044-box-info-synchro branch from 5984f94 to 0164f6f Compare September 23, 2022 08:08
@xuniq xuniq merged commit 73b6f2f into latest Sep 23, 2022
@xuniq xuniq deleted the gh-2044-box-info-synchro branch September 23, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants