Skip to content

Synchronous requests are not allowed in net.box triggers #2979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
Tracked by #2646 ...
TarantoolBot opened this issue Jun 24, 2022 · 0 comments · Fixed by #3603
Closed
2 tasks
Tracked by #2646 ...

Synchronous requests are not allowed in net.box triggers #2979

TarantoolBot opened this issue Jun 24, 2022 · 0 comments · Fixed by #3603
Assignees
Labels
2.11 2.11 release and the associated technical debt add details [nature] More details needed, some info missing. Documentation is incomplete. netbox [area] Related to net.box triggers [area] Related to triggers

Comments

@TarantoolBot
Copy link
Collaborator

TarantoolBot commented Jun 24, 2022

Related dev. issue: tarantool/tarantool#5358
Product: Tarantool
Since: 2.4.2
Audience/target: administrators, developers
Root document: https://www.tarantool.io/en/doc/latest/reference/reference_lua/net_box/#triggers
SME: @ locker

Details

An attempt to issue a synchronous request (e.g. call) from
net.box triggers on_connect and on_schema_reload now raises
an error: "Synchronous requests are not allowed in net.box trigger"
(Before tarantool/tarantool#5358 was
fixed, it silently hung.)

Invoking an asynchronous request (see is_async option) is allowed,
but the request will not be processed until the trigger returns and
an attempt to wait for the request completion with future:pairs()
or future:wait_result() will raise the same error.
Requested by @locker in tarantool/tarantool@0d944f9.

Definition of done

  • net.box triggers section explains that synchronous requests are not allowed
  • net.box triggers section explains how asynchronous requests are processed
@p7nov p7nov added 3sp triggers [area] Related to triggers add details [nature] More details needed, some info missing. Documentation is incomplete. netbox [area] Related to net.box labels Jun 30, 2022
@p7nov p7nov removed this from the Estimate [@p7nov] milestone Jul 1, 2022
@veod32 veod32 added 2.11 2.11 release and the associated technical debt and removed 3sp labels Mar 6, 2023
@p7nov p7nov self-assigned this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.11 2.11 release and the associated technical debt add details [nature] More details needed, some info missing. Documentation is incomplete. netbox [area] Related to net.box triggers [area] Related to triggers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants