🍒[cxx-interop] Do not emit C++ interop flag in textual interfaces #77989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please test with following PR: @swift-ci please test |
…lays If a Swift module built with library evolution enabled is an overlay of a C++ module, allow referring to the non-resilient C++ symbols from the Swift code. Overlays are usually built and shipped along with the C/C++ modules, so library evolution is less of a concern there. A developer providing a Swift overlay for a C++ library would expect to be able to refer to the symbols from the C++ library within the overlay. (cherry picked from commit f420456)
… overlay This fixes a CI job that is building the Swift stdlib with a recent nightly compiler. rdar://140850172 (cherry picked from commit b6488d3)
This makes sure that the compiler does not emit `-enable-experimental-cxx-interop`/`-cxx-interoperability-mode` flags in `.swiftinterface` files. Those flags were breaking explicit module builds. The module can still be rebuilt from its textual interface if C++ interop was enabled in the current compilation. rdar://140203932 (cherry picked from commit 7ae2beb)
egorzhdan
force-pushed
the
egorzhdan/6.1-swiftinterface-no-cxx-flag
branch
from
ee513eb to
f95338d
Compare
|
Please test with following PR: @swift-ci please test |
1 similar comment
|
Please test with following PR: @swift-ci please test |
Xazax-hun
approved these changes
Dec 17, 2024
DougGregor
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: This makes sure that the compiler does not emit
-enable-experimental-cxx-interop/-cxx-interoperability-modeflags in.swiftinterfacefiles. Those flags were breaking explicit module builds. The module can still be rebuilt from its textual interface if C++ interop was enabled in the current compilation.Scope: This alters the logic that emits and reads compiler flags from
.swiftinterfacefiles.Risk: Medium, this changes the textual interfaces emitted by the compiler, which can theoretically have adverse effects on dependencies of the current module.
Testing: This is covered by compiler tests.
Issue: rdar://140203932
Reviewer: @artemcm @Xazax-hun
Original PR: #77754