AST: Rename TypeRefinementContext to AvailabilityScope #77563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
hborla,
slavapestov,
xedin,
jckarter and
artemcm
as code owners
|
@swift-ci please smoke test |
artemcm
approved these changes
Nov 12, 2024
| @@ -1336,9 +1336,9 @@ def dump_scope_maps : Separate<["-"], "dump-scope-maps">, | |||
| MetaVarName<"<expanded-or-list-of-line:column>">, | |||
| ModeOpt, | |||
| Flags<[FrontendOption, NoInteractiveOption, DoesNotAffectIncrementalBuild]>; | |||
| def dump_type_refinement_contexts : | |||
There was a problem hiding this comment.
Please also update Options.swift in swift-driver.
There was a problem hiding this comment.
tshortli
force-pushed
the
rename-type-refinement-context
branch
from
ef7be10 to
67c5927
Compare
|
@swift-ci please smoke test |
tshortli
added a commit
to tshortli/swift-driver
that referenced
this pull request
Nov 12, 2024
Aligned with swiftlang/swift#77563.
tshortli
added a commit
to tshortli/swift-driver
that referenced
this pull request
Nov 12, 2024
Aligned with swiftlang/swift#77563.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the role
TypeRefinementContextby renaming it toAvailabilityScope. There are a few reasons for doing this, despite the churn:TypeRefinementContextis a fairly broad name that doesn't provide much of a hint about the primary purpose of this structure for most contributors. HavingAvailabilityin the name is clarifying.AvailabilityScopeis evocative ofASTScope, which is useful because the two represent very similar concepts and have similar structures.