stdlib: Enable upcoming MemberImportVisibility feature
#76665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
force-pushed
the
stdlib-enable-member-import-visibility
branch
from
6bb2eea to
3396de2
Compare
|
@swift-ci please smoke test |
tshortli
force-pushed
the
stdlib-enable-member-import-visibility
branch
2 times, most recently
from
fe40a23 to
d7a6181
Compare
tshortli
requested review from
artemcm,
ktoso,
zoecarver,
hyp,
egorzhdan and
Xazax-hun
as code owners
|
Now depends on #77662. |
tshortli
force-pushed
the
stdlib-enable-member-import-visibility
branch
3 times, most recently
from
ab8f30c to
f9dceaa
Compare
|
@swift-ci please smoke test |
tshortli
changed the title
MemberImportVisibility experimental featureMemberImportVisibility upcoming feature
tshortli
changed the title
MemberImportVisibility upcoming featureMemberImportVisibility feature
egorzhdan
reviewed
Nov 18, 2024
stdlib/public/Cxx/CMakeLists.txt
Outdated
Comment on lines
28
to
31
| # The varying modularization of the C++ standard library on different | ||
| # platforms makes it difficult to enable MemberImportVisibility for this | ||
| # module | ||
| -disable-upcoming-feature MemberImportVisibility |
There was a problem hiding this comment.
I think this flag should probably only be on the CxxStdlib module. The Cxx module doesn't import the C++ standard library and is mostly platform-independent.
tshortli
force-pushed
the
stdlib-enable-member-import-visibility
branch
from
f9dceaa to
471fec4
Compare
…ure to the frontend. The legacy driver is still used to build the compiler on Windows, so we need it to handle these new flags correctly in order to adopt them in the stdlib.
It was already supposed to be enabled, but I forgot to update the CMake when I renamed the feature from ExtensionImportVisibility to MemberImportVisibility. However, leave it disabled on the CxxStdlib module since the C++ standard library's modularization varies a lot by platform, making it difficult to add the right conditional imports.
tshortli
force-pushed
the
stdlib-enable-member-import-visibility
branch
from
471fec4 to
c9c3673
Compare
|
@swift-ci please smoke test |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was already supposed to be enabled, but I forgot to update the CMake when I renamed the feature from
ExtensionImportVisibilitytoMemberImportVisibility.However, leave it disabled on the CxxStdlib module since the C++ standard library's modularization varies a lot by platform, making it difficult to add the right conditional imports.