fix bad expansion of SWIFT_ENUM #63902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes 63837
QuietMisdreavus
requested review from
zoecarver,
hyp and
egorzhdan
as code owners
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test and merge |
|
@QuietMisdreavus I don't know what the release process looks like, but will this change and #63338 be cherry-picked into the 5.8 release branch? |
|
@devioustree I'm not sure about the exact state of things, but my impression so far is that the release branch is pretty locked-down. Let me see what i can do. |
|
Let me know if you need any support to argue for their inclusion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63837
When i introduced the data-driven creation of the Objective-C compatibility header, i accidentally introduced a difference in the macro expansion for
SWIFT_ENUM. This PR fixes this.