Skip to content

Embedded: don't link swiftrt.o for bare metal #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2024
Merged

Embedded: don't link swiftrt.o for bare metal #1533

merged 1 commit into from
Jan 29, 2024

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Jan 29, 2024 •
edited
Loading

When linking with swiftc for -unknown-none- triples, it attempts to link swiftrt.o runtime file, which is currently not needed and is not present for these triples. We should avoid linking it in these cases.

@MaxDesiatov
Embedded: don't link swiftrt.o for bare metal
ff2ac8b 
Currently when linking with `swiftc` for `-unknown-none-` triples, it attempts to link `swiftrt.o` runtime file, which is currently not needed and is not present for these triples. We should avoid linking it in these cases.
@MaxDesiatov MaxDesiatov added the bug Something isn't working label Jan 29, 2024
@MaxDesiatov MaxDesiatov self-assigned this Jan 29, 2024
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov MaxDesiatov added the embedded Changes related to Embedded Swift label Jan 29, 2024
@MaxDesiatov
Copy link
Contributor Author

MaxDesiatov commented Jan 29, 2024 •
edited
Loading

macOS failure looks unrelated

Assertion failed: (contextSpecificCache != ContextSpecificCacheMap.end() &&
  "Global Module Dependencies Cache not configured with context-specific " "state."),
  function getCacheForScanningContextHash, file ModuleDependencies.cpp, line 569.

@MaxDesiatov MaxDesiatov mentioned this pull request Jan 29, 2024
Open
rauhul
rauhul approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@rauhul rauhul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's also get artem to approve as well

artemcm
artemcm approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test macos

@MaxDesiatov MaxDesiatov merged commit ba1d273 into main Jan 29, 2024
@MaxDesiatov MaxDesiatov deleted the maxd/embedded-no-swiftrt branch January 29, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemcm artemcm artemcm approved these changes

@rauhul rauhul rauhul approved these changes

@kubamracek kubamracek Awaiting requested review from kubamracek

Assignees

@MaxDesiatov MaxDesiatov

Labels
bug Something isn't working embedded Changes related to Embedded Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaxDesiatov @artemcm @rauhul