Allow clients of Driver to pass DiagnosticsHandler
#1317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses of `DiagnosticsEngine` are deprecated in SwiftPM, since it uses a different logging infrastructure based on `ObservabilityScope` type. Resolving that deprecation warning is possible if `Driver.init` is able to take a diagnostics handler directly.
|
@swift-ci test |
owenv
reviewed
Mar 26, 2023
MaxDesiatov
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Mar 26, 2023
Since uses of `DiagnosticsEngine` are deprecated in SwiftPM, with swiftlang/swift-driver#1317 we can remove any traces of it from `Basics/Observability.swift` to clean that up.
owenv
approved these changes
Mar 26, 2023
|
@swift-ci test windows |
artemcm
approved these changes
Mar 27, 2023
MaxDesiatov
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Mar 27, 2023
Since uses of `DiagnosticsEngine` are deprecated in SwiftPM, with swiftlang/swift-driver#1317 we can remove any traces of it from `Basics/Observability.swift` to clean that up. Removed unused deprecated function that returned an instance of `DiagnosticsEngine`. Also broke up `import TSCBasic` into separate type imports to make clear what dependencies on TSC are there remaining. `TSCBasic.Diagnostic` still remains, but I think long-term we can move that to Swift Driver codebase to reduce dependencies on TSC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses of
DiagnosticsEngineare deprecated in SwiftPM, since it uses a different logging infrastructure based on its ownObservabilityScopetype. Resolving that deprecation warning is possible ifDriver.initis able to take a diagnostics handler directly.