upgrade Swift plugin to use llvm::Expected for GetIndexOfChildWithName #10593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (idx < UINT32_MAX && idx >= CalculateNumChildrenIgnoringErrors()) | ||
| return UINT32_MAX; | ||
| if ((idx == UINT32_MAX) || | ||
| (idx < UINT32_MAX && idx >= CalculateNumChildrenIgnoringErrors())) |
There was a problem hiding this comment.
idx < UINT32_MAX is now redundant, right?
There was a problem hiding this comment.
You are right, I assumed that the value could go higher but it's a uint32 not an uint.
| if (idx < UINT32_MAX && idx >= CalculateNumChildrenIgnoringErrors()) | ||
| return UINT32_MAX; | ||
| if ((idx == UINT32_MAX) || | ||
| (idx < UINT32_MAX && idx >= CalculateNumChildrenIgnoringErrors())) |
felipepiovezan
approved these changes
May 1, 2025
charles-zablit
force-pushed
the
charles-zablit/fix-merge-136693
branch
2 times, most recently
from
bf75a76 to
e12f551
Compare
charles-zablit
force-pushed
the
charles-zablit/fix-merge-136693
branch
from
e12f551 to
105d084
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
llvm/llvm-project, this PR changed the return type ofGetIndexOfChildWithName.This PR reflects those changes in the Swift plugin for LLDB.