Skip to content

csview's trim_left and trim_right implicitly assume LTR text #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
liigo opened this issue Oct 15, 2024 · 1 comment
Closed

csview's trim_left and trim_right implicitly assume LTR text #102

liigo opened this issue Oct 15, 2024 · 1 comment

Comments

@liigo
Copy link
Contributor

liigo commented Oct 15, 2024

see rust-lang/rust#30459
@tylov
Copy link
Collaborator

tylov commented Oct 15, 2024

Thanks, liigo! Since these are new, I simply renamed them to trim_start() and trim_end() as suggested. (also matches with starts_with() and ends_with() functions).
I also renamed all the _right(s, len) functions to _tail(s, len) (because _end() is used for iterators).

@tylov tylov closed this as completed Oct 15, 2024
tylov added a commit that referenced this issue Oct 15, 2024
@tylov
Fixed issue #102 "csview's trim_left and trim_right implicitly assume…
9f7311d 
… LTR text":

1. Renamed csview_trim_left() => csview_trim_start(), and csview_trim_right() => csview_trim_end().
2. Renamed all <str/view>_right() functions => _tail() for the same reason.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liigo @tylov