Skip to content

chore(template): Add regenerate-nix to pre-commit config #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 22, 2025
Merged

chore(template): Add regenerate-nix to pre-commit config #509

merged 3 commits into from
Apr 22, 2025

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Apr 22, 2025 •
edited
Loading

Part of #503

This PR:

  • adds the make regenerate-nix command as a pre-commit hook to keep Nix files up to date.
  • improves on which file changes the regenerate-charts hook runs.
  • improves in which stages the local pre-commit hooks run.

@Techassi Techassi self-assigned this Apr 22, 2025
@Techassi Techassi moved this to Development: Waiting for Review in Stackable Engineering Apr 22, 2025
NickLarsenNZ
NickLarsenNZ approved these changes Apr 22, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi added this pull request to the merge queue Apr 22, 2025
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Apr 22, 2025
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering Apr 22, 2025
Merged via the queue into main with commit e3613f8 Apr 22, 2025
2 checks passed
@Techassi Techassi deleted the chore/template-pre-commit branch April 22, 2025 15:10
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Apr 23, 2025
@NickLarsenNZ NickLarsenNZ mentioned this pull request Apr 23, 2025
Open
29 tasks
@NickLarsenNZ NickLarsenNZ added the release-retro/25.3.0 Indicates this issue or PR is part of improvements resulting from the Release Retro 25.3.0 label Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@Techassi Techassi

Labels
release-retro/25.3.0 Indicates this issue or PR is part of improvements resulting from the Release Retro 25.3.0
Projects
Stackable Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Techassi @NickLarsenNZ