CommandRegistration.Builder with lambdas #1142
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome! Thank you for your PR. I planned #1127 for the next release so it would be great if we can merge this PR in it. Can you please rebase it on the latest main and remove all formatting changes? Thank you upfront. |
fmbenhassine
added
the
status/need-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to fix issue #1127
I added all functions of
CommandRegistration.Builderthat have aConsumer<?Spec>to avoid chaining with the and function from specifications. This change improves code readability and indentation.This is my first contribution. Please let me know if there are any issues or if I need to make any adjustments.