Skip to content

Getting Started missing interactive flag #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cedric-tache opened this issue Jul 23, 2024 · 0 comments
Closed

Getting Started missing interactive flag #1108

cedric-tache opened this issue Jul 23, 2024 · 0 comments
Labels
area/documentation Belongs to documentation branch/3.3.x Issue for a branch for/backport For backporting
Milestone

Comments

@cedric-tache
Copy link

I tried following multiple articles and documentation to create my first Spring Shell project. The interactive shell never appeared.

I finally found the answer here: #1081

The Getting started section doesn't mention that I need to add the following property:

spring.shell.interactive.enabled=true

I couldn't test it yet, but I believe the following caution is not needed anymore with the default behavior of having the interactive shell disabled:

Given that Spring Shell starts the REPL (Read-Eval-Print-Loop) because this dependency is present, you need to either skip tests when you build (-DskipTests) throughout this tutorial or remove the sample integration test that was generated by [start.spring.io](https://start.spring.io/). If you do not remove it, the integration test creates the Spring ApplicationContext and, depending on your build tool, stays stuck in the eval loop or crashes with a NPE.
@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Jul 23, 2024
@jvalkeal jvalkeal added area/documentation Belongs to documentation and removed status/need-triage Team needs to triage and take a first look labels Aug 14, 2024
@jvalkeal jvalkeal changed the title Incomplete documentation - Getting Started not mentionning spring.shell.interactive.enabled=true Getting Started missing spring.shell.interactive.enabled=true Aug 14, 2024
@jvalkeal jvalkeal changed the title Getting Started missing spring.shell.interactive.enabled=true Getting Started missing interactive flag Aug 14, 2024
@jvalkeal jvalkeal added for/backport For backporting branch/3.3.x Issue for a branch labels Aug 14, 2024
@jvalkeal jvalkeal added this to the 3.4.0-M1 milestone Aug 14, 2024
jvalkeal added a commit that referenced this issue Aug 14, 2024
- Add note for interactive mode
- Backport #1108
- Fixes #1119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Belongs to documentation branch/3.3.x Issue for a branch for/backport For backporting
Projects
None yet
Development

No branches or pull requests

2 participants