Added ControllerActionBuilder with actionFor method. #71

dschulten · 2013-05-18T17:44:43Z

Improved support for requests which require that the client sends data to the server. The goal is not to rely on out-of-band information for this.

The new ActionDescriptor allows to create responses which tell the client how to send data to a resource, e.g. how to build POST and PUT bodies or which GET parameters to use in a query.

See the javadoc of ControllerActionBuilder and HtmlResourceMessageConverter for usage and SamplePersonController and HtmlResourceMessageConverterTest-context.xml for an example.
Currently using spring-test-mvc with WebContextLoader to stay compatible with Spring 3.1.x

See the javadoc of ControllerActionBuilder and HtmlResourceMessageConverter for usage and SamplePersonController and HtmlResourceMessageConverterTest-context.xml for an example. Currently using spring-test-mvc with WebContextLoader to stay compatible with Spring 3.1.x

removed code duplication in AnnotatedParametersParameterAccessor.getBoundMethodParameterValues

odrotbohm · 2013-05-27T12:41:08Z

This looks quite decent. Is there a chance you try to raise the version of the spring-test module to 3.2.3 individually and try to use the Spring 3.2 integration test framework. Although probably a bit weird at first glance I'd like to try this to avoid adding all the custom web test infrastructure code to the codebase.

Once we have that polished I can start polishing the code to get it merged. :)

dschulten · 2013-05-27T14:23:09Z

I tried that already, it didn't work due to class not found errors. That's
why I backported the tests to 3.1 :-)

odrotbohm · 2013-05-29T13:48:52Z

Guess what? Just raise the dependency to Spring 3.2.3 then. If one's interested in state-of-the-art hypermedia, you're probably able/willing to upgrade to an up-to-date Spring as well.

dschulten · 2013-05-29T16:32:24Z

OK, I'll do that :-) I'll also change the name createActionFor to
actionFor, if you don't mind.

odrotbohm · 2013-05-29T16:34:56Z

Go ahead, I'll probably apply some name changes here and there after some internal feedback here as well. I just wanted to make sure we don't start of with too much extra code in the first place. :)

Reverted fix for VndErrorsMarshallingTests, will apply the official fix

Conflicts: src/main/java/org/springframework/hateoas/mvc/ControllerLinkBuilderFactory.java src/test/java/org/springframework/hateoas/mvc/ControllerLinkBuilderUnitTest.java

Removed an incorrect comment stating that PUT will be part of HTML5, it won't be: http://www.w3.org/html/wg/wiki/User:Eoconnor/ISSUE-195

…er returning an array of HttpMessageConverters, not a List

dschulten · 2013-06-03T05:27:44Z

This is how an action could be represented in HAL: https://gist.github.com/dschulten/5696110, single-item form. The idea is, if I am a browser, I will get a form whereas if I am asking for application/hal+json I will get a hal resource.

felixbarny · 2013-10-08T18:09:56Z

Any plans on when this is going to be merged?

felixbarny · 2014-01-14T09:28:24Z

ping :)

dschulten · 2014-04-20T09:56:28Z

Hi Oliver, are you still interested in this? Is some work needed on my side to get this in?

aheusingfeld · 2015-03-09T00:44:34Z

@olivergierke could you please review this. The "method" support would be very much appreciated. Thanks. ;)

odrotbohm · 2015-03-09T11:19:54Z

To be honest, the more I look into it, the less I am convinced that merging this is a good idea:

we're basically stuck with something quite involved but still very rudimentary. Only @RequestParam is currently supported, no @PathVariable, no @ModelAttribute.
ControllerActionBuilder seems to be repeating a lot of code that already exists in the infrastructure and probably only works in the exact use case it was written for (what about proxied requests etc.)

In general, my biggest concern is that this is far from done and basically lacking a description of the general approach, its limitations. We currently don't have neither a form nor HTML strategy with Spring HATEOAS and I think that we need to come up with a more exhaustive concept to it before going forward with it. Open for suggestions.

dschulten · 2015-03-10T06:56:06Z

Since I am the author of that pull request: After the pull request never
made it into spring-hateoas, I have created a LinkBuilder implementation
called AffordanceBuilder [1]
which works as a drop-in replacement for ControllerLinkBuilder. It creates
an Affordance, which is a hateoas Link with additional traits (httpMethod,
RequestParam, RequestBody, multiple methods per rel). It also supports all
features of the RFC5988 Link header.

@olivergierke if you are interested I would be happy to create another pull
request which adds AffordanceBuilder back into spring-hateoas. I'll be at
JAX, maybe we can meet there.
After all, hydra-java stands firmly on the shoulders of spring-hateoas :)
Conceptually, AffordanceBuilder would be a better choice than this pull
request.

The goal of hydra-java is to support hypermedia types with "forms" support,
first hydra, but xhtml and uber converters are coming soon.

[1]
https://github.com/dschulten/hydra-java/blob/master/README.asciidoc#affordancebuilder-for-rich-hyperlinks-from-v-020
[2] https://github.com/dschulten/hydra-java/tree/master/spring-hateoas-ext

Am 09.03.2015 um 01:44 schrieb Alexander Heusingfeld:

@olivergierke https://github.com/olivergierke could you please review
this. The "method" support would be very much appreciated. Thanks. ;)

—
Reply to this email directly or view it on GitHub
#71 (comment).

odrotbohm · 2015-03-10T07:08:47Z

That's great news, Dietrich. As JAX is not too far away anymore. Shall we get together there and find some time to discuss things? Wouldn't mind @aheusingfeld joining us as he seems to be buys in that area, too.

aheusingfeld · 2015-03-10T07:20:39Z

I have created a LinkBuilder implementation called AffordanceBuilder [1] which works as a drop-in replacement for ControllerLinkBuilder. It creates an Affordance, which is a hateoas Link with additional traits (httpMethod, RequestParam, RequestBody, multiple methods per rel).

Great! That's almost exactly what I started with yesterday! Will look at your implementation instead. \o/

Wouldn't mind @aheusingfeld joining us as he seems to be buys in that area, too.

Yes. I'll be there Apr 21 - 23. Looking forward to see you there.

dschulten · 2015-03-10T13:20:22Z

My talk is on the 23rd at 17:00-18:00, so best after that or right after
Alexander's talk.

Dietrich

On March 10, 2015 8:08:51 AM Oliver Gierke [email protected] wrote:

That's great news, Dietrich. As JAX is not too far away anymore. Shall we
get together there and find some time to discuss things? Wouldn't mind
@aheusingfeld joining us as he seems to be buys in that area, too.

Reply to this email directly or view it on GitHub:
#71 (comment)

* Introduces new Affordances API to build links related to each other to serve other mediatypes * Introduces HAL-FORMS, which uses affordances to automatically generate HTML form data based on Spring MVC annotations. Original pull-request: #340, #447, #581 Related issues: #503, #334, #71

gregturn · 2017-11-29T20:15:43Z

Superceded by #612 and resolved via 70448a8.

Final solution isn't precisely the same thing, but we plan to iterate over it in the near future and expand to support other mediatypes. Feel free to check the HAL-FORMS section of code and their corresponding unit tests.

Also, see monitor Spring HATEOAS Examples repo as we plan to add an Affordances example very soon.

pivotal-issuemaster · 2017-11-29T20:15:44Z

@dschulten Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster · 2017-11-29T20:15:44Z

@dschulten Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

dschulten added 2 commits May 18, 2013 19:36

support formatting of parameter values in MethodParameterValue

320a9de

removed code duplication in AnnotatedParametersParameterAccessor.getBoundMethodParameterValues

ghost assigned odrotbohm May 31, 2013

dschulten mentioned this pull request Jun 1, 2013

Support for automatic creation of forms #34

Closed

dschulten added 5 commits June 1, 2013 12:50

using Spring 3.2.3 we can remove the older spring-test-mvc artifact

9d31922

Reverted fix for VndErrorsMarshallingTests, will apply the official fix

renamed createActionFor to actionFor

9a66b66

Merge remote-tracking branch 'remotes/upstream/master' into formSupport

c69434b

Conflicts: src/main/java/org/springframework/hateoas/mvc/ControllerLinkBuilderFactory.java src/test/java/org/springframework/hateoas/mvc/ControllerLinkBuilderUnitTest.java

Cleaned up unused imports

a1fc89e

Removed an incorrect comment stating that PUT will be part of HTML5, it won't be: http://www.w3.org/html/wg/wiki/User:Eoconnor/ISSUE-195

Fixed classcast exception as a result of AnnotationMethodHandlerAdapt…

05d7569

…er returning an array of HttpMessageConverters, not a List

darrin mentioned this pull request Mar 3, 2014

HAL compatibility and support not quite there… #159

Closed

odrotbohm force-pushed the master branch 2 times, most recently from 4ebc1be to 266ad50 Compare July 25, 2016 18:32

odrotbohm force-pushed the master branch from 0e8b0e1 to aafe1f2 Compare March 26, 2017 09:19

gregturn mentioned this pull request Aug 15, 2017

#340 - Adds new Affordances API + HAL-Forms mediatype #612

Closed

gregturn closed this Nov 29, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added ControllerActionBuilder with actionFor method. #71

Added ControllerActionBuilder with actionFor method. #71

dschulten commented May 18, 2013

odrotbohm commented May 27, 2013

dschulten commented May 27, 2013

odrotbohm commented May 29, 2013

dschulten commented May 29, 2013

odrotbohm commented May 29, 2013

dschulten commented Jun 3, 2013

felixbarny commented Oct 8, 2013

felixbarny commented Jan 14, 2014

dschulten commented Apr 20, 2014

aheusingfeld commented Mar 9, 2015

odrotbohm commented Mar 9, 2015

dschulten commented Mar 10, 2015

odrotbohm commented Mar 10, 2015

aheusingfeld commented Mar 10, 2015

dschulten commented Mar 10, 2015

gregturn commented Nov 29, 2017

pivotal-issuemaster commented Nov 29, 2017

pivotal-issuemaster commented Nov 29, 2017

Added ControllerActionBuilder with actionFor method. #71

Added ControllerActionBuilder with actionFor method. #71

Conversation

dschulten commented May 18, 2013

odrotbohm commented May 27, 2013

dschulten commented May 27, 2013

odrotbohm commented May 29, 2013

dschulten commented May 29, 2013

odrotbohm commented May 29, 2013

dschulten commented Jun 3, 2013

felixbarny commented Oct 8, 2013

felixbarny commented Jan 14, 2014

dschulten commented Apr 20, 2014

aheusingfeld commented Mar 9, 2015

odrotbohm commented Mar 9, 2015

dschulten commented Mar 10, 2015

odrotbohm commented Mar 10, 2015

aheusingfeld commented Mar 10, 2015

dschulten commented Mar 10, 2015

gregturn commented Nov 29, 2017

pivotal-issuemaster commented Nov 29, 2017

pivotal-issuemaster commented Nov 29, 2017