Skip to content

Add support to the Link class for the RFC 5988 attributes #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jstano opened this issue Aug 24, 2014 · 2 comments
Closed

Add support to the Link class for the RFC 5988 attributes #235

jstano opened this issue Aug 24, 2014 · 2 comments
Assignees
@gregturn
Milestone
0.24

Comments

@jstano
Copy link

jstano commented Aug 24, 2014 •
edited by gregturn
Loading

Add direct support for the following attributes:
anchor, hreflang, media, title, type using the standard with builder style method

In order to support link extensions, we could do something like
withExtension(String paramName, String paramValue)

I will submit a pull request with changes to support this enhancement.
@jstano jstano mentioned this issue Aug 24, 2014
Closed
@dschulten
Copy link
Contributor

Note that some param names may be repeated, others not.
The rev attribute is deprecated by rfc5988, it should not be a fixed attribute IMHO, could still be added as extension param.
The media attribute is also not immediately useful, it is about device-specific representations. Could also be added as extension, if needed.

Best regards,
Dietrich

drdamour referenced this issue Jan 22, 2016
@odrotbohm
#378 - HAL links get title attributes rendered resolved through a res…
71ec26f 
…ource bundle.

HalLinkListSerializer now tries to obtain a link title by looking up key _links.$rel.title for both the namespaced (curied) and local link relation if the former doesn't resolve into a message.
gregturn added a commit that referenced this issue Mar 21, 2017
@gregturn
Add extra attributes to Link and use for HAL mediatype
c606bfd 
Adds many additional attributes defined in RFC5988 and verifies they work properly in the neutral representation of Link while also being rendered properly in the HAL module.

Resolves #100,#417,#235,#240,#238,#223
gregturn added a commit that referenced this issue Mar 22, 2017
@gregturn
Add extra attributes to Link and use for HAL mediatype
1d7e27a 
Adds many additional attributes defined in RFC5988 and verifies they work properly in the neutral representation of Link while also being rendered properly in the HAL module.

Resolves #100,#417,#235,#240,#238,#223
gregturn added a commit that referenced this issue Mar 22, 2017
@gregturn
Add extra attributes to Link and use for HAL mediatype
ae30cff 
Adds many additional attributes defined in RFC5988 and verifies they work properly in the neutral representation of Link while also being rendered properly in the HAL module.

Additionally, some of the files had inconsistent EOL characters. This patches that as well. To see the differences WITHOUT this bit, add ?w=1 to the github page showing the delta, and whitespace differences will be filtered out.

Resolves #100,#417,#235,#240,#238,#223
@gregturn gregturn mentioned this issue Mar 22, 2017
Closed
gregturn added a commit that referenced this issue Mar 22, 2017
@gregturn
#560 - Add extra attributes to Link and use for HAL mediatype
b8a309f 
Adds many additional attributes defined in RFC5988 and verifies they work properly in the neutral representation of Link while also being rendered properly in the HAL module.

Additionally, some of the files had inconsistent EOL characters. This patches that as well. To see the differences WITHOUT this bit, add ?w=1 to the github page showing the delta, and whitespace differences will be filtered out.

Resolves #100,#417,#235,#240,#238,#223
gregturn added a commit that referenced this issue Mar 22, 2017
@gregturn
#560 - Add extra attributes to Link and use for HAL mediatype
574d824 
Adds many additional attributes defined in RFC5988 and verifies they work properly in the neutral representation of Link while also being rendered properly in the HAL module.

Additionally, some of the files had inconsistent EOL characters. This patches that as well. To see the differences WITHOUT this bit, add ?w=1 to the github page showing the delta, and whitespace differences will be filtered out.

Resolves #100,#417,#235,#240,#238,#223
gregturn added a commit that referenced this issue Mar 22, 2017
@gregturn
#560 - Add extra attributes to Link and use for HAL mediatype
ed2c67d 
Adds many additional attributes defined in RFC5988 and verifies they work properly in the neutral representation of Link while also being rendered properly in the HAL module.

Additionally, some of the files had inconsistent EOL characters. This patches that as well. To see the differences WITHOUT this bit, add ?w=1 to the github page showing the delta, and whitespace differences will be filtered out.

Resolves #100,#417,#235,#240,#238,#223
gregturn added a commit that referenced this issue Mar 22, 2017
@gregturn
#560 - Add extra attributes to Link and use for HAL mediatype
60e0b0a 
Adds many additional attributes defined in RFC5988 and verifies they work properly in the neutral representation of Link while also being rendered properly in the HAL module.

Additionally, some of the files had inconsistent EOL characters. This patches that as well. To see the differences WITHOUT this bit, add ?w=1 to the github page showing the delta, and whitespace differences will be filtered out.

Resolves #100,#417,#235,#240,#238,#223
gregturn added a commit that referenced this issue Mar 26, 2017
@gregturn
#560 - Add extra attributes to Link and use for HAL mediatype
2d94871 
Adds many additional attributes defined in RFC5988 and verifies they work properly in the neutral representation of Link while also being rendered properly in the HAL module.

Additionally, some of the files had inconsistent EOL characters. This patches that as well. To see the differences WITHOUT this bit, add ?w=1 to the github page showing the delta, and whitespace differences will be filtered out.

Resolves #100,#417,#235,#240,#238,#223
gregturn added a commit that referenced this issue Mar 26, 2017
@gregturn
Add extra attributes to Link and use for HAL mediatype
9d96a11 
Adds many additional attributes defined in RFC5988 and verifies they work properly in the neutral representation of Link while also being rendered properly in the HAL module.

Related tickets: #100, #417, #235, #240, #238, #223
@gregturn gregturn mentioned this issue Mar 26, 2017
Closed
gregturn added a commit that referenced this issue Mar 26, 2017
@gregturn
#567 - Add extra attributes to Link and use for HAL mediatype.
2dfa996 
Adds many additional attributes defined in RFC5988 and verifies they work properly in the neutral representation of Link while also being rendered properly in the HAL module.

Related tickets: #100, #417, #235, #240, #238, #223
gregturn added a commit that referenced this issue Mar 26, 2017
@gregturn
#567 - Add extra attributes to Link and use for HAL mediatype.
520122f 
Adds many additional attributes defined in RFC5988 and verifies they work properly in the neutral representation of Link while also being rendered properly in the HAL module.

Related tickets: #100, #417, #235
Previous pull requests: #240, #238, #223
@gregturn gregturn self-assigned this Mar 26, 2017
gregturn added a commit that referenced this issue Mar 26, 2017
@gregturn
#567 - Add extra attributes to Link and use for HAL mediatype.
57c90e4 
Adds many additional attributes defined in RFC5988 and verifies they work properly in the neutral representation of Link while also being rendered properly in the HAL module.

Related tickets: #100, #417, #235
Previous pull requests: #240, #238, #223, #79
gregturn added a commit that referenced this issue May 23, 2017
@gregturn
#567 - Add extra attributes to Link and use for HAL mediatype.
6f5a51e 
Adds many additional attributes defined in RFC5988 and verifies they work properly in the neutral representation of Link while also being rendered properly in the HAL module.

Related tickets: #100, #417, #235
Previous pull requests: #240, #238, #223, #79
odrotbohm pushed a commit that referenced this issue Jul 28, 2017
@gregturn @odrotbohm
#567 - Add extra attributes to Link and use for HAL mediatype.
891fd90 
Adds many additional attributes defined in RFC5988 and verifies they work properly in the neutral representation of Link while also being rendered properly in the HAL module.

Related tickets: #100, #417, #235
Previous pull requests: #240, #238, #223, #79
@odrotbohm
Copy link
Member

Fixed with #567.

@odrotbohm odrotbohm added this to the 0.24 milestone Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregturn gregturn

Labels
None yet
Projects
None yet
Milestone
0.24
Development

No branches or pull requests
4 participants
@dschulten @odrotbohm @gregturn @jstano