Add support for full outer join to SelectBuilder. #1421
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schauder
force-pushed
the
issue/full-outer-joins
branch
from
cb4773b to
b0a9ca0
Compare
Original pull request #1421
schauder
force-pushed
the
issue/full-outer-joins
branch
from
b0a9ca0 to
2dce16c
Compare
mp911de
approved these changes
Feb 23, 2023
| * @see Join | ||
| * @see SQL#table(String) | ||
| */ | ||
| SelectOn fullOuterJoin(TableLike table); |
There was a problem hiding this comment.
I wonder whether we should introduce a JoinType type to be more flexible and not always require a new method per join type. That type could describe INNER JOIN, LEFT/RIGHT joins, outer, cross, natural and many more of those.
There was a problem hiding this comment.
I agree, I will replace fullOuterJoin with join with an additional parameter.
|
As discussed I added a generic join method and merged it into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.