Throw VerificationException for build verification failures
#45187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verification failures are generally failures which verify correctness, e.g., failures caused by test, compilation, linting, etc. Non-verification failures are generally failures related to the build toolchain, e.g., failures caused by dependency resolution, build configuration, etc. Develocity attempts to classify failures based on context, but it doesn't always classify correctly. By default, most failures are classified as non-verification. By explicitly throwing a `VerificationException` for verification task failures, the failures will be appropriately classified. See also: https://docs.gradle.com/develocity/failure-classification Signed-off-by: Eric Haag <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
|
I determined these as being verification failures given the task names and their failure messages include To find these candidates, I checked the last 90 days of failures on ge.spring.io. It's possible there could be additional verification failures that I missed. |
philwebb
added
type: task
philwebb
pushed a commit
that referenced
this pull request
Apr 14, 2025
Verification failures are generally failures which verify correctness, e.g., failures caused by test, compilation, linting, etc. Non-verification failures are generally failures related to the build toolchain, e.g., failures caused by dependency resolution, build configuration, etc. Develocity attempts to classify failures based on context, but it doesn't always classify correctly. By default, most failures are classified as non-verification. By explicitly throwing a `VerificationException` for verification task failures, the failures will be appropriately classified. See gh-45187 See also: https://docs.gradle.com/develocity/failure-classification Signed-off-by: Eric Haag <[email protected]>
|
Thanks @erichaagdev! |
izeye
added a commit
to izeye/spring-javaformat
that referenced
this pull request
Apr 27, 2025
izeye
added a commit
to izeye/spring-javaformat
that referenced
this pull request
Apr 27, 2025
See spring-projects/spring-boot#45187 Signed-off-by: Johnny Lim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verification failures are generally failures which verify correctness, e.g., failures caused by test, compilation, linting, etc. Non-verification failures are generally failures related to the build toolchain, e.g., failures caused by dependency resolution, build configuration, etc.
Develocity attempts to classify failures based on context, but it doesn't always classify correctly. By default, most failures are classified as non-verification. By explicitly throwing a
VerificationExceptionfor verification task failures, the failures will be appropriately classified.Here is a Build Scan showing the behavior with these changes. You'll notice these
Architecture checkfailures are categorized as verification rather than non-verification, which is the case when you look in the Spring Develocity instance.See also: https://docs.gradle.com/develocity/failure-classification