Re-add @ConditionalOnEnabledTracing on BraveAutoConfiguration #38273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
This change was made as part of #35354, and mentioned in the |
scottfrederick
added
the
status: waiting-for-feedback
|
That explains! I had missed it in the release notes. We're doing something like this in Spring Boot Netflix to have similar behavior in tests, so this is good, actually. We'll have to rework a few assumptions, but that's easy enough. Thanks! |
scottfrederick
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ConditionalOnEnabledTracingused to be on theBraveAutoConfiguration. See this revision: https://github.com/spring-projects/spring-boot/blob/411586347c8fae00373028bac51dfd16e69661c5/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/tracing/BraveAutoConfiguration.javaIt's unclear to me from the git history why it was removed, and I think it's incorrect.
This is causing an issue with (testing) upgrading to 3.2 currently.