Skip to content

Add New Kafka Properties #7646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garyrussell opened this issue Dec 14, 2016 · 1 comment
Closed

Add New Kafka Properties #7646

garyrussell opened this issue Dec 14, 2016 · 1 comment
Labels
status: superseded An issue that has been superseded by another

Comments

@garyrussell
Copy link
Contributor

The kafka 0.10 client added max.poll.records - this is useful and should be exposed as a boot property.

Also, add a "catch-all" properties property (ala hibernate) to enable easier setting of other more exotic properties.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 14, 2016
garyrussell added a commit to garyrussell/spring-boot that referenced this issue Dec 16, 2016
@garyrussell
spring-projectsGH-7646: Additional Kafka Properties
45647de 
Resolves spring-projects#7646

Add `max.poll.records` and generic `properties.*`.
garyrussell added a commit to garyrussell/spring-boot that referenced this issue Dec 16, 2016
@garyrussell
spring-projectsGH-7646: Additional Kafka Properties
1f85b4c 
Resolves spring-projects#7646

Add `max.poll.records` and generic `properties.*`.
@garyrussell garyrussell mentioned this issue Dec 16, 2016
Closed
@sabbyanandan sabbyanandan mentioned this issue Dec 16, 2016
Closed
@philwebb
Copy link
Member

Closing in favor of PR #7672

@philwebb philwebb added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 16, 2016
garyrussell added a commit to garyrussell/spring-boot that referenced this issue Dec 16, 2016
@garyrussell
spring-projectsGH-7646: Dotted Custom Property
b0056bc 
Since kafka properties are generally dotted, add a test to ensure
dotted "catch-all" properties work.
garyrussell added a commit to garyrussell/spring-boot that referenced this issue Dec 16, 2016
@garyrussell
spring-projectsGH-7646: Polishing
505aa20 
Add back custom config example, using include.
garyrussell added a commit to garyrussell/spring-boot that referenced this issue Dec 16, 2016
@garyrussell
spring-projectsGH-7646: Polishing
3728281 
Add back custom config example, using include.
philwebb added a commit that referenced this issue Dec 21, 2016
@philwebb
Merge pull request #7672 from garyrussell/GH-7646
85ed902 
* pr/7672:
  Polish Kafka properties
  Support arbitrary Kafka properties
@philwebb philwebb added status: superseded An issue that has been superseded by another and removed status: duplicate A duplicate of another issue labels Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@garyrussell @philwebb @spring-projects-issues