Skip to content

Fix javadoc in JdbcCursorItemReaderBuilder #4838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix javadoc in JdbcCursorItemReaderBuilder #4838

wants to merge 1 commit into from

Conversation

itis821
Copy link

@itis821 itis821 commented May 8, 2025

  • JdbcCursorItemReaderBuilder.queryTimeout(int) -> milliseconds
  • but, AbstractCursorItemReader.setQueryTimeout(int) -> seconds

@itis821
Fix javadoc in JdbcCursorItemReaderBuilder
3d20632 
  - JdbcCursorItemReaderBuilder.queryTimeout(int) -> milliseconds
  - but, AbstractCursorItemReader.setQueryTimeout(int) -> seconds

Signed-off-by: Jisu Lee <[email protected]>
@itis821
Copy link
Author

itis821 commented May 8, 2025

JdbcCursorItemReaderBuilder's build() method calls JdbcCursorItemReader.setQueryTimeout(int). This setQueryTimeout(int) method is actually defined in AbstractCursorItemReader.setQueryTimeout(int). Therefore, the queryTimeout parameter from JdbcCursorItemReaderBuilder is passed as an argument to AbstractCursorItemReader.setQueryTimeout(). However, there's an issue where the javadoc specifies different units for this timeout value between JdbcCursorItemReaderBuilder and AbstractCursorItemReader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@itis821