updated SimpleStepBuilder to assign ItemProcessor lambda at construction #3897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| builder.build().execute(execution); | ||
|
|
||
| assertEquals(BatchStatus.COMPLETED, execution.getStatus()); | ||
|
|
||
| List<? extends String> writtenItems = itemWriter.getWrittenItems(); | ||
| List<? extends String> writtenItems = ((ListItemWriter) itemWriter).getWrittenItems(); |
There was a problem hiding this comment.
This change (which is not related to the main goal of the fix) has introduced a warning about an unchecked assignment. The warning could be fixed by using an explicit type like ((ListItemWriter<String>) itemWriter), but this makes the cast redundant. I will revert that change on merge.
|
LGTM. Rebased and merged as 58e82a5. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3749