Skip to content

Batch table relationship description seems to be wrong. #4653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chaenabi opened this issue Aug 23, 2024 · 6 comments
Open

Batch table relationship description seems to be wrong. #4653

chaenabi opened this issue Aug 23, 2024 · 6 comments

Comments

@chaenabi
Copy link

StackOverflow.

Hello,
after writing the question above I couldn't pay attention for a while.
if the above issue is still valid, please concern to correct the description picture.

The photo and file below are a list of attached files for requesting correction.
(The zip file is a Mysql Workbench model diagram (mwb extension) file.)

batch_erd
batch_erd.zip

@chaenabi chaenabi added the status: waiting-for-triage Issues that we did not analyse yet label Aug 23, 2024
@fmbenhassine
Copy link
Contributor

Thank you for opening this issue. The SO thread refers to an outdated version of the documentation (v3).

The diagram was updated to v5 in #4358, so I think this issue can be closed. Let me know if you see another required update.

@fmbenhassine fmbenhassine closed this as not planned Won't fix, can't repro, duplicate, stale Sep 3, 2024
@fmbenhassine fmbenhassine added status: declined Features that we don't intend to implement or Bug reports that are invalid or missing enough details and removed status: waiting-for-triage Issues that we did not analyse yet labels Sep 3, 2024
@chaenabi
Copy link
Author

chaenabi commented Sep 3, 2024

Thanks for the reponse.
I wonder it looks like the updated picture still describes at #4358
BATCHSTEP_EXCEUTION_CONTEXT / BATCH_STEP_EXECUTION tables as many to one relationship
(BATCH_JOB_EXECUTION / BATCH_JOB_EXECUTION_CONTEXT too)
aren't each table a one-to-one relationship anymore?

@fmbenhassine
Copy link
Contributor

I see. This is actually the output of MySQL workbench for the given schema, which seems to be inaccurate (I don't see how to alter that). However, the corresponding text describing the tables is accurate:

There is exactly one Job ExecutionContext for each JobExecution, [...]

Is that what you are looking for?

@chaenabi
Copy link
Author

chaenabi commented Sep 4, 2024

yes I am.
if this is acceptable to you, you may see the picture #4653 to update

@fmbenhassine
Copy link
Contributor

OK I see the difference with your update (relations are now one-to-one), thank you for doing that! 👍

I will re-open this issue and plan the fix for the next release.

@fmbenhassine fmbenhassine reopened this Sep 5, 2024
@fmbenhassine fmbenhassine added in: documentation type: bug and removed status: declined Features that we don't intend to implement or Bug reports that are invalid or missing enough details labels Sep 5, 2024
@fmbenhassine fmbenhassine added this to the 5.2.0 milestone Sep 5, 2024
@fmbenhassine fmbenhassine added the for: backport-to-5.1.x Issues that will be back-ported to the 5.1.x line label Sep 5, 2024
@fmbenhassine fmbenhassine modified the milestones: 5.2.0, 5.2.0-RC1 Sep 16, 2024
@fmbenhassine fmbenhassine modified the milestones: 5.2.0-RC1, 5.2.0 Oct 23, 2024
@fmbenhassine fmbenhassine modified the milestones: 5.2.0, 5.2.1 Nov 20, 2024
@fmbenhassine fmbenhassine modified the milestones: 5.2.1, 5.2.2 Dec 18, 2024
@fmbenhassine fmbenhassine removed the for: backport-to-5.1.x Issues that will be back-ported to the 5.1.x line label Feb 26, 2025
@fmbenhassine
Copy link
Contributor

I will plan this for v6 and rework all diagrams with something other than MySQL workbench (to avoid having to reverse engineer the diagram every time).

@fmbenhassine fmbenhassine modified the milestones: 5.2.2, 6.0.0 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants