-
Notifications
You must be signed in to change notification settings - Fork 33
Intscala 55 - logging channel adapter DSL components #17
base: master
Are you sure you want to change the base?
Conversation
Hi @sobychacko, Could you rebase this PR? It looks like this PR contains some more code for INTSCALA-54. Also, please add one or two tests to Thanks! |
@ghillert PR is rebased and updated with unit test. |
* @author Soby Chacko | ||
* | ||
*/ | ||
object loggingChannel { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should call this log (like the vert to log ;-)
I feel the class-name for the logger is not perfect, yet - Instead of LoggingChannelAdapterEndpoint.scala, maybe better call it LoggerEndpointDsl.scala. I believe that aligns better with the rest of the DSL. |
@sobychacko Sorry, did finally some more thinking about it... I think we also should support the following optional properties:
The default log-level shall be info.
Not sure, yet, what the perfect DSL would look like...
|
LoggingChannelAdapterEndpoint to LoggerEndpointDsl; supports log withFullMessage; supports various log levels; supports SpEL expressions; logger name is optional; adding more unit tests and dsl usage demo's
@ghillert PR is updated again by incorporating the comments you made. Please take a look and see what you think. |
No description provided.