Skip to content

Fix #4221: napoleon depends on autodoc, but users need to load it man… #4233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 12, 2017
Merged

Fix #4221: napoleon depends on autodoc, but users need to load it man… #4233

merged 2 commits into from
Nov 12, 2017

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Nov 11, 2017

refs #4221

@RobRuana Where else do I need to update the way to set up?

@tk0miya tk0miya added this to the 1.6.6 milestone Nov 11, 2017
@tk0miya tk0miya requested a review from RobRuana November 11, 2017 13:04
RobRuana
RobRuana approved these changes Nov 11, 2017
View reviewed changes
Copy link
Contributor

@RobRuana RobRuana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tk0miya
Copy link
Member Author

tk0miya commented Nov 12, 2017

Thank you for reviewing!

@tk0miya tk0miya merged commit 0c98d04 into sphinx-doc:stable Nov 12, 2017
@tk0miya tk0miya deleted the 4221_napoleon_loads_autodoc_explicitly branch November 12, 2017 02:32
@tk0miya tk0miya mentioned this pull request Nov 12, 2017
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RobRuana RobRuana RobRuana approved these changes

Assignees
No one assigned
Labels
extensions:napoleon type:bug
Projects
None yet
Milestone
1.6.6
Development

Successfully merging this pull request may close these issues.
2 participants
@tk0miya @RobRuana