Skip to content

Fix query combo box not scoping created resources to other collection #3283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

maxpatiiuk
Copy link
Member

Fixes #2405
Fixes #3078
Also, allows unhiding all fields in autogenerated forms (in the meta menu when you say "use autogenerated form", there is now also a new checkbox)

Theresa was correct - there is a generic solution to this to fix it in all places

@maxpatiiuk maxpatiiuk requested review from grantfitzsimmons, melton-jason and a team March 31, 2023 21:50
Triggered by 1ed7f58 on branch refs/heads/issue-2405
@grantfitzsimmons
Copy link
Member

#3293

This issue is severe enough that it may be necessary to forbid creating new taxon records and only offer the ability to associate existing ones.

Copy link
Member

@grantfitzsimmons grantfitzsimmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing the ability to create records in the destination discipline as the form uses elements from the current discipline. Only the query combo box is searching the destination tree.

Copy link
Contributor

@chanulee1 chanulee1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seem to be unable to set batch of agents for collection access. Setting agents and saving clears the fields.

4TM55lRxIR.mp4

https://herbumass-issue-2405.test.specifysystems.org/specify/security/user/61/

@melton-jason melton-jason requested a review from a team December 11, 2023 04:08
@melton-jason
Copy link
Contributor

melton-jason commented Dec 11, 2023

Still seem to be unable to set batch of agents for collection access. Setting agents and saving clears the fields.

4TM55lRxIR.mp4
https://herbumass-issue-2405.test.specifysystems.org/specify/security/user/61/

Can this (#2405) be tested again?

@melton-jason melton-jason removed their request for review December 11, 2023 04:11
@maxpatiiuk maxpatiiuk self-assigned this Dec 23, 2023
Copy link
Contributor

@pashiav pashiav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Page gets stuck on loading popup after clicking Add User. Does not happen on edge.

issue-2405.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot set batch of agents for collection access Cannot add Host Taxon
5 participants