Skip to content

Control+C does not work when reading batch spec as standard input #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Piszmog opened this issue Jun 8, 2022 · 2 comments · Fixed by #794
Closed

Control+C does not work when reading batch spec as standard input #775

Piszmog opened this issue Jun 8, 2022 · 2 comments · Fixed by #794
Assignees
@mrnugget @BolajiOlajide
Labels
bug Something isn't working estimate/0.5d team/code-search

Comments

@Piszmog
Copy link
Contributor

Piszmog commented Jun 8, 2022 •
edited
Loading

A user is not able to exit with ctrl+c from src-cli when providing a batch spec as standard input. ctrl+d does work for exiting the program.

Steps

Run the following command,

src batch preview -f -

Try to exit the program with ctrl+c or ctrl+x.
@Piszmog Piszmog added bug Something isn't working team/code-search labels Jun 8, 2022
@BolajiOlajide
Copy link
Contributor

Hey @LawnGnome , I ran into this issue recently. I didn't know an issue had already being created for this, is it okay if I take this off your hands as I already have a fix for it?

@BolajiOlajide BolajiOlajide mentioned this issue Jun 21, 2022
Closed
@LawnGnome LawnGnome assigned BolajiOlajide and unassigned LawnGnome Jun 21, 2022
@LawnGnome
Copy link
Contributor

All yours, @BolajiOlajide!

mrnugget added a commit that referenced this issue Jun 23, 2022
@mrnugget
Cancel reading from stdin on Ctrl-C
3d3ce9b 
This is essentially a copy-paste implementation of the ideas presented
in this comment here: golang/go#20280 (comment)

It fixes #775 and helps with the issue described in #793 (comment). Not sure if it has unintended side-effects.
@mrnugget mrnugget mentioned this issue Jun 23, 2022
Merged
BolajiOlajide pushed a commit that referenced this issue Jul 7, 2022
@mrnugget @BolajiOlajide
Cancel reading from stdin on Ctrl-C
219d25e 
This is essentially a copy-paste implementation of the ideas presented
in this comment here: golang/go#20280 (comment)

It fixes #775 and helps with the issue described in #793 (comment). Not sure if it has unintended side-effects.
BolajiOlajide added a commit that referenced this issue Jul 7, 2022
@mrnugget @BolajiOlajide
Cancel reading from stdin on Ctrl-C (#794)
ef2ba4d 
* Cancel reading from stdin on Ctrl-C

This is essentially a copy-paste implementation of the ideas presented
in this comment here: golang/go#20280 (comment)

It fixes #775 and helps with the issue described in #793 (comment). Not sure if it has unintended side-effects.

* Add comments and remove interface

* update changelog

Co-authored-by: BolajiOlajide <[email protected]>
scjohns pushed a commit that referenced this issue Apr 24, 2023
@mrnugget @BolajiOlajide
Cancel reading from stdin on Ctrl-C (#794)
3e81919 
* Cancel reading from stdin on Ctrl-C

This is essentially a copy-paste implementation of the ideas presented
in this comment here: golang/go#20280 (comment)

It fixes #775 and helps with the issue described in #793 (comment). Not sure if it has unintended side-effects.

* Add comments and remove interface

* update changelog

Co-authored-by: BolajiOlajide <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrnugget mrnugget

@BolajiOlajide BolajiOlajide

Labels
bug Something isn't working estimate/0.5d team/code-search
Projects
None yet
Milestone
No milestone
4 participants
@LawnGnome @mrnugget @BolajiOlajide @Piszmog