Move all tests to tests/ folder. #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The folder is provided by Cargo and makes it easier to find tests.
|
I’m not exactly opposed to this change, but I don’t understand: what’s the point? Are they really hard to find where they are now? http://doc.crates.io/guide.html#tests describes the two places to have tests as "should be unit tests" and "should be integration tests" but the difference is not really clear to me.
|
|
My point is just that all other crates I know use the tests/ directory to for integration tests and I consider the tests using test files as integration tests. |
|
Chatting on IRC, other people seem to agree with this change. @bors-servo r+ |
|
📌 Commit befcf7c has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 23, 2015
Move all tests to tests/ folder. The folder is provided by Cargo and makes it easier to find tests. Question: I found that src/parser.rs contains many parsers, should I move `parse_ipv4addr` and `parse_ipv6addr` to the parsers file? <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/139) <!-- Reviewable:end -->
|
☀️ Test successful - travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The folder is provided by Cargo and makes it easier to find tests.
Question: I found that src/parser.rs contains many parsers, should I move
parse_ipv4addrandparse_ipv6addrto the parsers file?