Fix effective directive for inline checks #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jdm do you mind reviewing this one so I can start a WPT try run on servo/servo#36510 ? |
|
Oops, I assumed this was in the upstream repository! |
jdm
approved these changes
Apr 15, 2025
|
Yikes, some kind of dependency issue blocking CI :( |
|
Um, how's that related to this change? Upstream CI is green. I fear I don't know enough Rust yet to figure out what's going on here. |
|
Wait, I think #1 already introduced this issue. Will take a look. |
A directive can imply other directives. For example, the `script-src` implies the `script-src-elem` directive. Rather than returning the `script-src` as violated directive, we need to return `script-src-elem`.
TimvdLippe
force-pushed
the
pr-timvdlippe-fix-effective-directive
branch
from
b9d8bd5 to
013c596
Compare
|
TimvdLippe
force-pushed
the
pr-timvdlippe-fix-effective-directive
branch
from
013c596 to
ccd42e2
Compare
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Apr 17, 2025
This also ensures that document now reports all violations and we set the correct directive. With these changes, all `script-src-attr-elem` WPT tests pass. Part of #36437 Requires servo/rust-content-security-policy#3 to land first Signed-off-by: Tim van der Lippe <[email protected]>
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Apr 17, 2025
This also ensures that document now reports all violations and we set the correct directive. With these changes, all `script-src-attr-elem` WPT tests pass. Part of #36437 Requires servo/rust-content-security-policy#3 to land first Signed-off-by: Tim van der Lippe <[email protected]>
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Apr 17, 2025
This also ensures that document now reports all violations and we set the correct directive. With these changes, all `script-src-attr-elem` WPT tests pass. Part of #36437 Requires servo/rust-content-security-policy#3 to land first Signed-off-by: Tim van der Lippe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A directive can imply other directives. For example, the
script-srcimplies thescript-src-elemdirective. Rather than returning thescript-srcas violated directive, we need to returnscript-src-elem.