Suspend the whole tokenizer and tree builder on </script> #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ms2ger
reviewed
Nov 3, 2016
| @@ -404,19 +409,19 @@ impl<Sink: TokenSink> Tokenizer<Sink> { | |||
| self_closing: self.current_tag_self_closing, | |||
| attrs: replace(&mut self.current_tag_attrs, vec!()), | |||
| }); | |||
| self.process_token(token); | |||
| ; | |||
There was a problem hiding this comment.
Potato fingers. I wonder how the tests passed though...
|
@bors-servo r+ Reviewed 8 of 9 files at r1, 1 of 1 files at r2, 3 of 3 files at r3, 1 of 1 files at r4. Comments from Reviewable |
|
📌 Commit 40580bb has been approved by |
|
@bors-servo r- I am dumb, you can't know which script halted the tokenizer as the code is currently. |
nox
changed the title
|
@bors-servo r+ Reviewed 10 of 10 files at r5. Comments from Reviewable |
|
📌 Commit 7a268f3 has been approved by |
|
⚡ Test exempted - status |
bors-servo
pushed a commit
that referenced
this pull request
Nov 8, 2016
Suspend the whole tokenizer and tree builder on </script> <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/231) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is