Skip to content

Rewrite all the bindings with the new CF bindings #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tracked by #719
bors-servo opened this issue Feb 1, 2018 · 3 comments
Open
Tracked by #719

Rewrite all the bindings with the new CF bindings #162

bors-servo opened this issue Feb 1, 2018 · 3 comments

Comments

@bors-servo
Copy link
Contributor

Issue by nox
Thursday Oct 13, 2016 at 12:39 GMT
Originally opened as servo/core-graphics-rs#58

This is a work in progress.

This change is Reviewable

nox included the following code: https://github.com/servo/core-graphics-rs/pull/58/commits
@bors-servo
Copy link
Contributor Author

Comment by nox
Thursday Oct 13, 2016 at 12:40 GMT

I removed the dependency on Serde for now because I'm not sure it should live here.

This PR demonstrates the usefulness of CFMut, which guarantees for the &mut methods on CGContext that we have unique ownership of the drawing context.

@bors-servo
Copy link
Contributor Author

Comment by nox
Thursday Oct 13, 2016 at 12:44 GMT

I also removed the evil private module because it doesn't seem used by anyone.

@bors-servo
Copy link
Contributor Author

Comment by bors-servo
Saturday Oct 29, 2016 at 18:22 GMT

☔ The latest upstream changes (presumably #60) made this pull request unmergeable. Please resolve the merge conflicts.

jrmuizel pushed a commit to jrmuizel/core-foundation-rs that referenced this issue Feb 2, 2018
Auto merge of servo#162 - Eijebong:bump_graphics, r=emilio
58162a1 
Allow core-graphics 0.8 and bump version

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/cocoa-rs/162)
<!-- Reviewable:end -->
@madsmtm madsmtm mentioned this issue Mar 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bors-servo