Fix unused cmap in render_points #432
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test

test_plot_coloring_with_cmap
in the tests for points was wrongly passing. When switching from the use ofget_categorical_obs
to_get_categorical_color_mapping
, thecmap
was not anymore in the arguments. This led to the default colors always being used despite a colormap being defined. This PR fixes that issue by updating_get_categorical_color_mapping
.On main:
With this PR:
