Skip to content

Fix norm behavior, add tests #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Mar 5, 2025
Merged

Conversation

Sonja-Stockhaus
Copy link
Collaborator

should solve #418 and #372

@Sonja-Stockhaus Sonja-Stockhaus linked an issue Feb 4, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 95.74468% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.20%. Comparing base (cf42151) to head (e5e6a39).

Files with missing lines Patch % Lines
src/spatialdata_plot/pl/utils.py 89.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
+ Coverage   83.83%   85.20%   +1.37%     
==========================================
  Files           8        8              
  Lines        1732     1751      +19     
==========================================
+ Hits         1452     1492      +40     
+ Misses        280      259      -21     
Files with missing lines Coverage Δ
src/spatialdata_plot/pl/basic.py 89.26% <100.00%> (ø)
src/spatialdata_plot/pl/render.py 96.89% <100.00%> (+5.73%) ⬆️
src/spatialdata_plot/pl/utils.py 78.27% <89.47%> (+0.26%) ⬆️

@Sonja-Stockhaus Sonja-Stockhaus marked this pull request as ready for review February 19, 2025 19:12
@timtreis
Copy link
Member

timtreis commented Mar 5, 2025

@Sonja-Stockhaus don't ask what fixed it, no idea 🥸

Copy link
Member

@timtreis timtreis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@timtreis timtreis merged commit cad33a1 into main Mar 5, 2025
4 checks passed
@timtreis timtreis deleted the bugfix/372-norm-tests-and-clipping branch March 5, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing tests for norm=Normalize(...)
4 participants